Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added sample env variables for client and server #641

Merged

Conversation

ChinoUkaegbu
Copy link
Contributor

Fixes #638

My PR closes #638

πŸ‘¨β€πŸ’» Changes proposed

I added the extra sample env variables to both the server and client files

βœ”οΈ Check List

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Copy link

vercel bot commented Aug 12, 2024

@ChinoUkaegbu is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 12, 2024

@ChinoUkaegbu change the title to fit what you did and not what the PR closes, treat it like you're writing a commit message follow this guide(will link them at the end)
but in summary it should be [prefix]: [what you did]

how to write what you did

how to pick which prefix to use

@ChinoUkaegbu ChinoUkaegbu changed the title fix: Closes #638 docs: Added sample env variables for client and server Aug 12, 2024
@ChinoUkaegbu
Copy link
Contributor Author

Thanks, I've edited the title to reflect that!

server/.env_sample Outdated Show resolved Hide resolved
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 140e846 into Dun-sin:main Aug 12, 2024
1 of 3 checks passed
@ChinoUkaegbu ChinoUkaegbu deleted the docs-add-extra-env-sample-variables branch August 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] add extra variables to env_sample
2 participants