Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consistent name for room #599

Merged
merged 8 commits into from
Jan 24, 2024
Merged

refactor: consistent name for room #599

merged 8 commits into from
Jan 24, 2024

Conversation

Dun-sin
Copy link
Owner

@Dun-sin Dun-sin commented Jan 24, 2024

Fixes Issue

**My PR closes #592 **

👨‍💻 Changes proposed (What did you do ?)

  • changed naming to be consistent

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
whisper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 5:26pm

Dun-sin
Dun-sin commented Jan 24, 2024
View reviewed changes
src/pages/searching.tsx Outdated Show resolved Hide resolved
@Dun-sin
Copy link
Owner Author

Dun-sin commented Jan 24, 2024

@mathiasayivor please review

mathiasayivor
mathiasayivor requested changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@mathiasayivor mathiasayivor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

room and currentroom is a bit confusing; When you first see, you may think room is an object representing a room, but it's a string, same thing applies to currentroom.

Can we use roomId/currentRoomId instead?

src/server/models/ActiveUserModel.ts Outdated Show resolved Hide resolved
src/pages/searching.tsx Outdated Show resolved Hide resolved
@mathiasayivor
Copy link
Collaborator

LGTM

@Dun-sin Dun-sin merged commit 1160ad3 into main Jan 24, 2024
4 checks passed
@Dun-sin Dun-sin deleted the consistent-name-for-room branch January 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasayivor mathiasayivor mathiasayivor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER] keep consistant naming for chat rooms
4 participants
@Dun-sin @mathiasayivor @MJinH @DevDaniloFerrari