-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Room not found #584
fix: Room not found #584
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel. @Dun-sin first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Will review this later in the day @MJinH in the mean time, please remove the package files, don't delete them but remove them from your PR. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove everything that doesn't have to do with the issue, like changing name or formatting?
Also why are you calling context twice as we've already called it in PageWrapper.tsx, so either you remove it from there and leave your changes or vice versa, but can't be both
Could you please check this? in the ChatContext.tsx file, when the name is "chatId" in the createChat, it seems to result in 'undefined' in the chatReducer as shown in the image. When using 'id', it looks like it's assigned correctly. Please let me know if i missed something. Also, yes you're right. I forgot to remove the context in the PageWrapper.tsx file. |
i guess the issue comes from here:
not thisπ Whisper/src/reducer/chatReducer.ts Line 24 in 94b3b50
|
got it, and if the provider is in PageWrapper, the createChat in anonymous.tsx doesn't seem to be called properly. When debugging, it gets called as I'll fix those and recommit later. Thank you. |
Also @MJinH what exactly do you mean in Anonmyous.tsx? |
What I mean is, when ChatProvider is in PageWrapper, createChat is exeucted like this |
I see your point, yours is a better way thenπͺπ½ but the other things still count |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. ππ½hereππ½
Fixes Issue
**My PR closes #577 **
π¨βπ» Changes proposed(What did you do ?)
commented out the lines in anonymous.tsx file. Had an issue where the socket would connect on the server side but immediately disconnect on the client side, which was causing the
NEW_EVENT_CHAT_RESTORE
event to not work properly.After debugging, noticed that the
createChat
function wasn't being called properly in the anonymous.tsx file. suspect this was because it was being called before the provider was initialized, so wrapped the components withChatProvider
in the _app.tsx file and confirmed that it was working correctly.βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots