-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement profile picture #343 #558
feat: Implement profile picture #343 #558
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel. @Dun-sin first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
client/src/pages/UserAvatar.jsx
Outdated
@@ -0,0 +1,34 @@ | |||
import { HiUserCircle, HiPencil } from 'react-icons/hi'; | |||
|
|||
const UserAvatar = (prop) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please spread the props like other components, then use proptypes. you can see what i mean by looking at other components and this should be in the component folder but the pages' folder because it's a component not a page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Can the docs also be updated on how to configure vision? |
Let the PR be merged first, I will but there's no point when it's not yet merged, like chill |
should I update? |
Yes it's much better you do it, so it all gets merged together. Add it to the Readme steps. |
β¦b.com/hubsMIT1/Whisper into implement-profile-picture-Dun-sin#343
β¦b.com/hubsMIT1/Whisper into implement-profile-picture-Dun-sin#343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great, thanks for implementing my changes
Fixes Issue #343
**My PR closes #343 **
π¨βπ» Changes proposed(What did you do ?)
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots
https://drive.google.com/file/d/1A10Gfon7JnLGqyImLPX62llo6RC-LrrK/view?usp=sharing