Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement profile picture #343 #558

Merged
merged 21 commits into from
Nov 7, 2023

Conversation

hubsMIT1
Copy link
Contributor

Fixes Issue #343

**My PR closes #343 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Created a UserAvatar file for profile picture
  • Added schema for profile image
  • Used Google Vision API to check unsafe content in pictures

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

https://drive.google.com/file/d/1A10Gfon7JnLGqyImLPX62llo6RC-LrrK/view?usp=sharing

@vercel
Copy link

vercel bot commented Oct 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@hubsMIT1 hubsMIT1 changed the title Implement profile picture #343 feat: Implement profile picture #343 Oct 29, 2023
server/.env_sample Outdated Show resolved Hide resolved
@@ -0,0 +1,34 @@
import { HiUserCircle, HiPencil } from 'react-icons/hi';

const UserAvatar = (prop) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please spread the props like other components, then use proptypes. you can see what i mean by looking at other components and this should be in the component folder but the pages' folder because it's a component not a page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

client/src/pages/UserAvatar.jsx Outdated Show resolved Hide resolved
server/controllers/userController.js Outdated Show resolved Hide resolved
client/src/components/UserAvatar.jsx Outdated Show resolved Hide resolved
client/src/pages/Profile.jsx Show resolved Hide resolved
@mathiasayivor
Copy link
Collaborator

Can the docs also be updated on how to configure vision?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 29, 2023

Can the docs also be updated on how to configure vision?

Let the PR be merged first, I will but there's no point when it's not yet merged, like chill

@hubsMIT1 hubsMIT1 closed this Oct 29, 2023
@hubsMIT1 hubsMIT1 reopened this Oct 29, 2023
@hubsMIT1
Copy link
Contributor Author

Can the docs also be updated on how to configure vision?

Let the PR be merged first, I will but there's no point when it's not yet merged, like chill

should I update?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 30, 2023

Can the docs also be updated on how to configure vision?

Let the PR be merged first, I will but there's no point when it's not yet merged, like chill

should I update?

Yes it's much better you do it, so it all gets merged together. Add it to the Readme steps.

client/src/App.jsx Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
server/.env_sample Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
client/src/pages/Profile.jsx Show resolved Hide resolved
server/.env_sample Outdated Show resolved Hide resolved
server/package.json Outdated Show resolved Hide resolved
client/src/pages/Profile.jsx Outdated Show resolved Hide resolved
client/src/components/UserAvatar.jsx Show resolved Hide resolved
client/src/pages/Profile.jsx Outdated Show resolved Hide resolved
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for implementing my changes

@Dun-sin Dun-sin merged commit 15ba8c3 into Dun-sin:main Nov 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Profile picture
3 participants