Improve update-extension-dependencies.sh

Dufgui · Feb 12, 2021 · cb3cb4e · cb3cb4e
1 parent 81b9cd2
commit cb3cb4e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/ci-actions.yml b/.github/workflows/ci-actions.yml
@@ -95,7 +95,7 @@ jobs:
       - name: Verify extension dependencies
         shell: bash
         run: |
-          ./update-extension-dependencies.sh
+          ./update-extension-dependencies.sh -B --settings .github/mvn-settings.xml
           if [ `git status -s -u no '*pom.xml' | wc -l` -ne 0 ]
           then
             echo -e '\033[0;31mError:\033[0m Dependencies to extension artifacts are outdated! Run ./update-extension-dependencies.sh and add the modified pom.xml files to your commit.' 1>&2

diff --git a/update-extension-dependencies.sh b/update-extension-dependencies.sh
@@ -8,7 +8,7 @@ shopt -s failglob
 echo ''
 echo 'Building bom-descriptor-json...'
 echo ''
-mvn clean package -f devtools/bom-descriptor-json
+mvn -e clean package -f devtools/bom-descriptor-json -Denforcer.skip $*
 
 DEP_TEMPLATE='        <dependency>
             <groupId>io.quarkus</groupId>
@@ -28,7 +28,16 @@ echo ''
 echo 'Building dependencies list from bom-descriptor-json...'
 echo ''
 
+# get all "artifact-id" values from the generated json file
+# pipefail is switched off briefly so that a better error can be logged when nothing is found
+set +o pipefail
 ARTIFACT_IDS=`grep -Po '(?<="artifact-id": ")(?!quarkus-bom)[^"]+' devtools/bom-descriptor-json/target/*.json | sort`
+set -o pipefail
+if [ -z "${ARTIFACT_IDS}" ]
+then
+  echo -e '\033[0;31mError:\033[0m Could not find any artifact-ids. Please check the grep command. ' 1>&2
+  exit 1
+fi
 
 # to replace newlines with \n so that the final sed calls accept ${DEPS_*} as input
 SED_EXPR_NEWLINES=':a;N;$!ba;s/\n/\\\n/g'