Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find another location where get_ikind results in an error #41

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Find another location where get_ikind results in an error #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0589587
Find another location where get_ikind results in an error
Dudeldu Jul 15, 2022
ff56a9e
Further refine determining safe casts with floats
Dudeldu Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/cdomains/valueDomain.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,14 @@ struct
let is_safe_cast t2 t1 = match t2, t1 with
(*| TPtr _, t -> bitsSizeOf t <= bitsSizeOf !upointType
| t, TPtr _ -> bitsSizeOf t >= bitsSizeOf !upointType*)
| TInt (ik,_), TFloat (fk,_) (* does a1 fit into ik's range? *)
| TFloat (fk,_), TInt (ik,_) (* can a1 be represented as fk? *)
-> false (* TODO precision *)
| TFloat (fk1,_), TFloat (fk2,_) when fk1 = fk2 -> true
| TFloat (FDouble,_), TFloat (FFloat,_) -> true
| TFloat (FLongDouble,_), TFloat (FFloat,_) -> true
| TFloat (FLongDouble,_), TFloat (FDouble,_) -> true
| _, TFloat _ -> false (* casting float to an integral type always looses the decimals *)
| TFloat ((FFloat | FDouble | FLongDouble), _), TInt((IBool | IChar | IUChar | ISChar | IShort | IUShort), _) -> true (* resonably small integers can be stored in all fkinds *)
| TFloat ((FDouble | FLongDouble), _), TInt((IInt | IUInt | ILong | IULong), _) -> true (* values stored in between 16 and 32 bits can only be stored in at least doubles *)
| TFloat _, _ -> false (* all wider integers can not be completly put into a float, partially because our internal representation of long double is the same as for doubles *)
| _ -> IntDomain.Size.is_cast_injective ~from_type:t1 ~to_type:t2 && bitsSizeOf t2 >= bitsSizeOf t1
(*| _ -> false*)

Expand Down