Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Added a missing type definition for onStartShouldSetPanResponder/onMoveShouldSetPanResponder functions #57

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

npoussu
Copy link
Contributor

@npoussu npoussu commented Mar 3, 2021

Fixes TypeScript error "TS7051: Parameter has a name but no type. Did you mean 'arg3: any'?"

@@ -50,8 +50,8 @@ declare module '@dudigital/react-native-zoomable-view' {
onZoomAfter?: (event: Event, gestureState: PanResponderGestureState, zoomableViewEventObject: ZoomableViewEvent) => boolean;
onZoomEnd?: (event: Event, gestureState: PanResponderGestureState, zoomableViewEventObject: ZoomableViewEvent) => boolean;
onLongPress?: (event: Event, gestureState: PanResponderGestureState) => void;
onStartShouldSetPanResponder?: (event: Event, gestureState: PanResponderGestureState, zoomableViewEventObject: ZoomableViewEvent, any) => boolean;
onMoveShouldSetPanResponder?: (event: Event, gestureState: PanResponderGestureState, zoomableViewEventObject: ZoomableViewEvent, any) => boolean;
onStartShouldSetPanResponder?: (event: Event, gestureState: PanResponderGestureState, zoomableViewEventObject: ZoomableViewEvent, baseComponentResult: boolean) => boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming for the parameter is taken from the parent repository docs.

https://github.com/DuDigital/react-native-zoomable-view#pan-responder-hooks

@SimonErich SimonErich merged commit 9113b1c into DuDigital:master Jun 10, 2021
@SimonErich
Copy link
Contributor

Thank you very much for your contribution @npoussu . Really appreciate it! :)

@SimonErich SimonErich mentioned this pull request Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants