Don't use nullable types on primitive to avoid tons of (un)boxing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type Int? in Kotlin JVM maps to reference type Integer. It causes memory allocations. In our case, nullability isn't necessary and can be avoided. To save compatibility with the last version of the library, on some variables types are explicitly marked. _activeThumb's type is changed to non-nullable because the library never expects variable to be null.
|
Looks good and in my opinion, it is okay to break compatibility for this, if you want to, of course, otherwise I will accept it as-is. |
# Conflicts: # timerangepicker/src/main/java/nl/joery/timerangepicker/DefaultClockRenderer.kt # timerangepicker/src/main/java/nl/joery/timerangepicker/TimeRangePicker.kt
# Conflicts: # timerangepicker/src/main/java/nl/joery/timerangepicker/TimeRangePicker.kt
|
Conflicts fixed! |
saeed-lotfi
reviewed
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Int? in Kotlin JVM maps to reference type Integer. It causes memory allocations. In our case, nullability isn't necessary and can be avoided.
To save compatibility with the last version of the library, some variables types are explicitly marked.
Maybe we should break compatibility and then, boxed types won't be used at all.