Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing $ in export, dep init #7

Closed
wants to merge 1 commit into from
Closed

Removing $ in export, dep init #7

wants to merge 1 commit into from

Conversation

brokenthumbs
Copy link

@brokenthumbs brokenthumbs commented Dec 8, 2017

Noticed that the export commands were including a $ before each of the values. Not sure if it was intentional, but it was interfering with the shell environment variables in my Docker containers, since env would report FOO=$bar instead of FOO=bar. Let me know if I'm off base here for the PR.

Also using dep to install the aws dependencies. https://github.com/golang/dep
Initialized with brew install --upgrade dep && dep init

Tested the binary this time, and verifying intended behavior from pull request change.

Going from

$ aws-env
export FOO=$bar
export CAT=$dog

Changed to

$ aws-env
export FOO=bar
export CAT=dog

Thanks!

@orfin
Copy link
Contributor

orfin commented Dec 26, 2017

Thanks @brokenthumbs for PR.

$ are intentional - they allow to handle multiline parameters. It seems that you used bash that by default does not support it. Please check out 2nd point here which describes this behavior and how to fix it by just changing default docker bash: https://github.com/Droplr/aws-env#considerations

Antoni

@brokenthumbs
Copy link
Author

I completely overlooked that piece of information in the considerations, re: https://github.com/Droplr/aws-env#considerations

Tried it out with the command to use /bin/bash instead of /bin/sh, and that makes it work as intended.

Closing! Thanks for the reply.

@orfin
Copy link
Contributor

orfin commented Dec 29, 2017

Great to hear that it worked for you :-)
Cheers!

berga pushed a commit to berga/aws-env that referenced this pull request Sep 29, 2021
eval parameters from stdout for readonly file systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants