Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi path support #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gsoyka
Copy link
Contributor

@gsoyka gsoyka commented Nov 21, 2018

  • Adds ability to specify multiple colon separated paths, like in the $PATH variable.

@orfin
Copy link
Contributor

orfin commented Nov 29, 2018

Thanks @gsoyka for the contribution.
IMHO we should think how will it work for users that use colon notation for naming parameters.
This may break backward compatibility for use-cases such as: AWS_ENV_PATH=prod:service-1

What do you think? Are we able to handle multiple param names using different notation, or maybe should we move AWS_ENV_PATH as CLI option so it will be more natural to support multiple parameters? $ aws-env --path=prod/foo --path=prod/bar

@chizou
Copy link

chizou commented Nov 30, 2018

@orfin We decided to go with using the colon because
a) It mimics every major OS' PATH scheme of colon separated paths
b) AWS Parameter Store doesn't allow colons in the names of paths: https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-parameter-name-constraints.html

So there would be no conflicts

@ghost
Copy link

ghost commented Sep 5, 2019

Any update with this PR? it would be a nice feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants