Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor preference to the DroidplannerPrefs class. #840

Merged
merged 1 commit into from
Jul 1, 2014
Merged

Refactor preference to the DroidplannerPrefs class. #840

merged 1 commit into from
Jul 1, 2014

Conversation

arthurbenemann
Copy link
Member

As requested at #838 (comment).

arthurbenemann added a commit that referenced this pull request Jul 1, 2014
@arthurbenemann
Merge pull request #840 from arthurbenemann/refactorVolumePreference
b360da2 
Refactor preference to the DroidplannerPrefs class.
@arthurbenemann arthurbenemann merged commit b360da2 into DroidPlanner:master Jul 1, 2014
@arthurbenemann arthurbenemann deleted the refactorVolumePreference branch July 1, 2014 03:47
@m4gr3d
Copy link
Member

m4gr3d commented Jul 1, 2014

@arthurbenemann looks like you used the wrong method. You're using keepScreenOn instead of maxVolumeOnStart.

@arthurbenemann arthurbenemann mentioned this pull request Jul 1, 2014
Merged
@arthurbenemann arthurbenemann restored the refactorVolumePreference branch July 1, 2014 03:48
@arthurbenemann arthurbenemann mentioned this pull request Jul 1, 2014
Merged
@arthurbenemann
Copy link
Member Author

@ne0fhyk Thanks again. I probably should drop the computer at this time. Fixed at #841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurbenemann @m4gr3d