-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth device selection screen #598
Bluetooth device selection screen #598
Conversation
* @author Fredia Huya-Kouadio | ||
* @since 1.2.0 | ||
*/ | ||
public class BTDeviceSelectionActivity extends SuperActivity { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain me why there is a new activity class?
It works very nicely, it's just that I don't understand the need for a activity?
Wouldn't a FragmentDialog be enough for it?
…s now displayed by invoking a dialog fragment from SuperActivity.
@ne0fhyk There is a problem at m4gr3d@3a6b22c, when selecting the device to connect it returns to the android home screen instead of the app home screen. But the connections is established. Also if you are going to fix it make a merge from master, because there is a conflict in the strings.xml file. |
…ion. added string resources for the bluetooth device selection screen.
@arthurbenemann the fix is in place, and it was merged with latest from master. |
Thanks, that fixed all problems. |
…on_screen Bluetooth device selection screen
Based on pull #439, this branch only includes the bluetooth device selection screen (bluetooth server section is omitted), and should solve issue #590.