Bluetooth device selection screen #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great patch. I felt it needed a screenshot for documentation: |
| * @author Fredia Huya-Kouadio | ||
| * @since 1.2.0 | ||
| */ | ||
| public class BTDeviceSelectionActivity extends SuperActivity { |
There was a problem hiding this comment.
Can you explain me why there is a new activity class?
It works very nicely, it's just that I don't understand the need for a activity?
Wouldn't a FragmentDialog be enough for it?
…s now displayed by invoking a dialog fragment from SuperActivity.
|
@ne0fhyk There is a problem at m4gr3d@3a6b22c, when selecting the device to connect it returns to the android home screen instead of the app home screen. But the connections is established. Also if you are going to fix it make a merge from master, because there is a conflict in the strings.xml file. |
…ion. added string resources for the bluetooth device selection screen.
|
@arthurbenemann the fix is in place, and it was merged with latest from master. |
|
Thanks, that fixed all problems. |
arthurbenemann
added a commit
that referenced
this pull request
Jan 22, 2014
…on_screen Bluetooth device selection screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on pull #439, this branch only includes the bluetooth device selection screen (bluetooth server section is omitted), and should solve issue #590.