Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.verticalScroll(rememberScrollState())を追加しました #915

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

.verticalScroll(rememberScrollState())を追加しました #915

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a501158
少し変えました
honoka5 Sep 1, 2024
216b926
verticalScrollを追加しました
honoka5 Sep 1, 2024
38ca3f3
verticalScrollの場所を変更しました
honoka5 Sep 8, 2024
2d4bae8
エラー内容を消しました
honoka5 Sep 8, 2024
e661981
./gradlew detekt --auto-correct実行しました
honoka5 Sep 8, 2024
34a5ad6
Merge branch 'main' into cannot-be-scrolled
honoka5 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...re/sessions/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/SearchScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.imePadding
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
Expand Down Expand Up @@ -149,7 +151,9 @@ fun SearchScreen(
containerColor = MaterialTheme.colorScheme.surface,
) { innerPadding ->
Column(
modifier = Modifier.padding(top = innerPadding.calculateTopPadding()),
modifier = Modifier
.padding(top = innerPadding.calculateTopPadding())
.verticalScroll(rememberScrollState()),
Copy link
Member

@takahirom takahirom Sep 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プルリクエストありがとうございます！このComposable関数は普通の検索結果も入るので、ここにverticalScrollを設定すると、ここでの指定と、検索結果の表示で、両方縦のスクロールができてしまうため、検索結果を表示するときにエラーになってしまうようです。EmptySearchResultBodyという関数内でverticalScrollをつけてみるのはどうでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かしこまりました！ありがとうございます！やってみます！

) {
HorizontalDivider()
SearchFilters(
Expand Down
Loading