Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Media Feature Impl #543

Merged
merged 5 commits into from
Jul 9, 2021
Merged

[iOS] Media Feature Impl #543

merged 5 commits into from
Jul 9, 2021

Conversation

ostk0069
Copy link
Collaborator

@ostk0069 ostk0069 commented Jul 8, 2021

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • make sure repository connected to media screen

Links

Screenshot

Before After

@ostk0069 ostk0069 requested a review from ry-itto July 8, 2021 15:35
@github-actions github-actions bot temporarily deployed to deploygate-distribution July 8, 2021 15:44 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution July 8, 2021 16:24 Inactive
ry-itto
ry-itto approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a layout off like below (spacing). But it's okey. if it is not good, fix it with another issue.

スクリーンショット 2021-07-09 1 17 04

@ostk0069
Copy link
Collaborator Author

ostk0069 commented Jul 9, 2021

There is a layout off like below (spacing). But it's okey. if it is not good, fix it with another issue.

This problem seems to happen by using GeometryReader in SmallCard.
As you know, we are using GeometryReader to resize the image for NukeUI.LazyImage
I will take a look about this with other opportunity.

@ry-itto ry-itto merged commit 0c5088a into main Jul 9, 2021
@ry-itto ry-itto deleted the media-feature-impl branch July 9, 2021 12:35
@ostk0069 ostk0069 mentioned this pull request Jul 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostk0069 @ry-itto