Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local time setting is misconfigured #198

Open
ytRino opened this issue Feb 8, 2017 · 5 comments
Open

Local time setting is misconfigured #198

ytRino opened this issue Feb 8, 2017 · 5 comments

Comments

@ytRino
Copy link
Member

ytRino commented Feb 8, 2017

Overview (Required)

  • problem 1.
    Local time is not applied after we changed that setting even if restarting app (even if remove from recent and launch again).
  • problem 2.
    We change phone time zone and back to app, local time is applied when local time setting is on or off.

Step to reproduce

  1. Change time zone to Taipei(GMT+8)
  2. Install and launch app. Welcome talk show start at 10:00.
  3. Go to setting tab and turn on local time. Go to session tab and it still shows 10:00.
  4. Remove from recent and launch app and it shows 10:00 again. Expected: 9:00 (problem 1.)
  5. Change phone locale to Bangkok(GMT+7) and back to app. It shows 9:00
    • This time, display date is changing if local time setting is on or off (problem 2.)
  6. Do step 4. and it show 10:00 again.

I notice that step 5, Bangkok(GMT+7) shows not 8:00 but 9:00. It seems LocalUtil expect Tokyo(GMT+9) for args, but it is 10:00 at Taipei(GMT+8) because of problem 1, so it produces 1h diff from 10:00. (Maybe solved when problem 1or2 get fixed)

@konifar
Copy link
Contributor

konifar commented Feb 8, 2017

Sorry, this local time setting has not been implemented yet 🙇

@ytRino
Copy link
Member Author

ytRino commented Feb 8, 2017

ah ok, LocaleUtil is checking this so i thought it was implemented.
never mind

@Pluu
Copy link
Contributor

Pluu commented Feb 14, 2017

Can I use ThreeTen Backport?
or, Only just use JAVA 7?

@konifar
Copy link
Contributor

konifar commented Feb 14, 2017

@Pluu It's okay to introduce ThreeTenABP 👍

@Pluu
Copy link
Contributor

Pluu commented Feb 15, 2017

I think Issue is this.
The same "date type" data is in a different state.

Step to reproduce

Check Session ==> 3.9 10:00 Welcome talk
Check Field ==> Session#stime (java.util.Date)

  1. Change time zone to Taipei(GMT+8)
  2. Show local time Setting ==> On
  3. App Restart
  4. Session#stime : Thu Mar 09 10:00:00 GMT+08:00 2017
  5. Press Recent App Key or Home Key
  6. Device Setting ==> Change time zone to Tokyo(GMT+9)
  7. App Launcher Click
  8. Session#stime : Thu Mar 09 11:00:00 GMT+09:00 2017

😱 😱 😱 😱 😱

I will try it in another way.

Pluu added a commit to Pluu/conference-app-2017 that referenced this issue Feb 16, 2017
- DroidKaigi#198

## Desc

- Add, ThreeTenABP
- Add, Gson Custom TypeAdapter (ZonedDateTimeSerializer, ZonedDateTimeDeserializer)
- Change Data type Date -> ZonedDateTime (Session stime/etime)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants