Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.x Shift #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Laravel 6.x Shift #1

wants to merge 7 commits into from

Conversation

Dreknor
Copy link
Owner

@Dreknor Dreknor commented Jan 25, 2022

This pull request includes the changes for upgrading to Laravel 6.x. Feel free to commit any additional changes to the shift-54367 branch.

Before merging, you need to:

  • Checkout the shift-54367 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, add --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

Shift automatically applies the Laravel coding style - which uses the PSR-2 coding style as a base with some minor additions.

You may customize the adopted coding style by adding a [PHP CS Fixer][1] or [PHP CodeSniffer][2] config to your project root. Feel free to use [Shift's Laravel ruleset][3] to help you get started.

For more information on customizing the code style applied by Shift, [watch this short video][4].

[1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
[2]: https://github.com/squizlabs/PHP_CodeSniffer
[3]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
[4]: https://laravelshift.com/videos/shift-code-style
PHP 5.5.9+ adds the new static `class` property which provides the fully qualified class name. This is preferred over using class name strings as these references are checked by the parser.
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.
@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 6 versions and merge any changes:

  • app/Http/Kernel.php

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

⚠️ Laravel 6.x consolidated references to /home as a constant within the RouteServiceProvider. This makes it easier to maintain and change in a single place.

Shift automated this change, but could not upgrade the following files since they differed from the default Laravel version. You should compare these files against the default Laravel 6 versions and merge this change:

  • app/Http/Controllers/Auth/RegisterController.php

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert c9746bee and make the config file changes manually.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Laravel 6 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Shift updated your dependencies for Laravel 6. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 6.

Watch dealing with dependencies for tips on handling any additional package incompatibilities.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ The Eloquent model's toArray() method will now cast any attributes that implement Illuminate\Contracts\Support\Arrayable to an array. While unlikely to impact your application, this change could effect code which relies upon the previous data type or output.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Laravel 6 now requires Carbon 2. While Shift reviewed your application for common breaking changes, you may want to review the Carbon 2 migration notes for additional changes.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Laravel 6 made some changes to the email verification routes. First, to prevent CSRF attacks the email/resend has been changed from a GET to a POST route. Second, a hash parameter was added to the email/verify route.

If you were calling these routes in your application code, you will need to adjust the requests accordingly.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Laravel 6 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@Dreknor
Copy link
Owner Author

Dreknor commented Jan 25, 2022

🎉 Congratulations, you've made it to the latest LTS version. However, Shift encourages you to keep going to the latest Laravel version. No reason to remain on this older version and acquire technical debt when you're so close...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants