Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App refactoring #28

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

App refactoring #28

wants to merge 37 commits into from

Conversation

NathanBnm
Copy link

@NathanBnm NathanBnm commented Jan 11, 2020

Changelog

  • Switch to meson build system
  • Better translation integration (with meson)
  • Add French translation
  • Fix some warnings
  • Add favourite heart icon in a column (this can be improved)
  • Remove deprecated code

There is still things to do. But this this a first step. The app is building and working well.

This PR is ready for review

@georgesofianosgr
Copy link
Member

georgesofianosgr commented Jan 12, 2020

Wow, these are a lot of changes for a single pull request.
Unfortunately I currently don't have access to elementary OS to test it and accept it.

Some notes/questions:

  • I like the change to the meson build system.
  • Can you explain the "Add translation capability" ? You could already translate the app.
  • Why about modal should be removed ?
  • Is SQLHeavy available in elementary PPA ? Because after elementary OS luna you had to install the deb package manual. I'm asking this because you removed it from the README

@NathanBnm
Copy link
Author

NathanBnm commented Jan 12, 2020

@georgesofianosgr

Wow, these are a lot of changes for a single pull request.

I'm sorry I worked a lot on it and I didn't think to better separate the changes between them.

Unfortunately I currently don't have access to elementary OS to test it and accept it.

Can't you try it with a virtual machine? It's working well on my side.

Some notes/questions:

* I like the change to the meson build system.

It's quite the elementary standard now.

* Can you explain the "Add translation capability" ? You could already translate the app.

I didn't mean it that way, I meant with meson. I'll edit this.

* Why about modal should be removed ?

I contributed to a lot of elementary apps and it seems to be mentioned as deprecated by the elementary community. I think it's kind of because author credits are already mentioned in AppCenter.

* Is SQLHeavy available in elementary PPA ? Because after elementary OS luna you had to install the deb package manual. I'm asking this because you removed it from the README

Unfortunately not. And this is an issue I forgot to submit. But SQLHeavy is deprecated and cannot be installed via ppa. I have so much trouble to install it. Would it be possible to move to sqlite?

Just let me know if you have any questions 😄
I thought this project was kind of dead so I wasn't expecting an answer so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants