refactor(process): 调整arch_switch_to_user函数，把riscv和x86_64的共用逻辑抽取出来。 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switch_to_user to run_init_process 调整arch_switch_to_user函数，把riscv和x86_64的共用逻辑抽取出来。写成run_init_process函数，并且能够尝试运行多个不同的init程序，直到某个运行成功
dragonosbot
added
O-riscv64
GnoCiYeH
reviewed
Apr 26, 2024
kernel/src/init/initial_kthread.rs
Outdated
|
|
||
| unsafe { arch_switch_to_user(path, argv, envp) }; | ||
| unsafe { arch_switch_to_user(trap_frame) }; |
There was a problem hiding this comment.
感觉这个函数的调用在switch_to_user里面更合适，代码功能性区分会更明确一点
|
|
||
| fn try_to_run_init_process(path: &str) -> Result<(), SystemError> { | ||
| if let Err(e) = run_init_process(path.to_string()) { | ||
| if e != SystemError::ENOENT { |
There was a problem hiding this comment.
从switch_to_user来看，init程序的启动是有优先级的，所以我觉得这里的日志应该更完善一点，提示当前是运行哪个init程序，前面的为什么出错。
There was a problem hiding this comment.
会有报错的，在那个exec那里就会报出错误的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(process): Extract common logic for riscv and x86_64 in arch_switch_to_user to run_init_process
调整arch_switch_to_user函数，把riscv和x86_64的共用逻辑抽取出来。写成run_init_process函数，并且能够尝试运行多个不同的init程序，直到某个运行成功