Miscellaneous changes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts an imperative algorithm into a functional one.
The function that gets the values array from the configuration now: - Sorts the entries by range. The ranges are sorted in ascending "start" values. - Now that the array is sorted, this function goes through and checks to see if any ranges overlap.
The previous version iterated through the array until it found the entry that contained the index. Now that the values array is sorted, we can switch to the binary search function.
These tests make sure reading the `values` array from the config properly sort and check for overlap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few little changes I made when going through the recent code that I added.
mapdrivermapdrivermapdriver