Improve weather driver #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when both the precip rate and precip total went to zero, the last total would get set to the total before it was reset. It turns out that many weather stations simply accumulate all the day's rainfall and resets at night, which is not a very smart algorithm. The new algorithm is that the total gets reset (and the last total gets updated) when the rainfall rate is 0 for a certain amount of time. A Google search found some research that suggested a 10 hour gap of rain was a good average to indicate separate weather systems. So after 10 hours of no rainfall, the totals will get updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version improves the
precip-rate,precip-total, andprecip-last-totaldevices.Weather stations accumulate rainfall for 24 hours and reset the total at midnight. It doesn't matter how many separate storm systems occur, there's one total for the day.
This pull request identifies rainfall more than 10 hours apart as a separate event and updates the
precip-last-totalaccordingly.