Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When syncing multiple vaults at once, they can run in parallel? #2

Closed
DovieW opened this issue Nov 5, 2023 · 4 comments
Closed

When syncing multiple vaults at once, they can run in parallel? #2

DovieW opened this issue Nov 5, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@DovieW
Copy link
Owner

DovieW commented Nov 5, 2023

No description provided.

@DovieW DovieW added the enhancement New feature or request label Nov 5, 2023
@DovieW DovieW changed the title When syncing multiple vaults at once, they can run in the background to improve performance When syncing multiple vaults at once, they can run in parallel? Dec 22, 2023
@DovieW
Copy link
Owner Author

DovieW commented Dec 24, 2023

This will also greatly simplify issues with syncing the correct vault first since we can just have all vaults sync everytime and any way that the app is opened

@DovieW
Copy link
Owner Author

DovieW commented Jan 21, 2024

Can simply run each sync in the background with the & operator and use the wait command to wait for all to complete.

Can technically have a lock file per vault and not need to hold up the que for all vaults to finish. Overkill

@DovieW
Copy link
Owner Author

DovieW commented Dec 26, 2024

With 5 vaults, syncing all takes <3 seconds if running in parralel. While synchronously it takes >13 seconds

DovieW added a commit that referenced this issue Dec 26, 2024
@DovieW
Copy link
Owner Author

DovieW commented Dec 26, 2024

this might've messed up the notification on error thing (wasn't working either way), and messed up outputting the log while the sync command is running (i was lazy). less necessary now since using the worktree fix meaning less issues to monitor

@DovieW DovieW closed this as completed Dec 26, 2024
@DovieW DovieW pinned this issue Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant