Accepting config dict to setup a Configuration instance without using an ini file #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darth30joker
requested changes
Aug 17, 2020
|
@nimesulide Just want to start a discussion that should we still support python 2? we all know it's coming to an end, and support is already stopped from Jan 1st this year. |
|
I'm not against supporting python 2, but I haven't seen anybody using it for a long time. |
|
I kind of think we should deprecate python 2 now, but I don't want to break existing usage... |
|
We can remove it, and then I'll just put the types back, also then I'll increase version number to 1.0.0, so it's a non-backward compatible release. What do you think? |
|
This is perfect, let's do it! |
…t back typing to config init parameter
|
Pushed it, hope it'll work like this. :) |
darth30joker
approved these changes
Aug 17, 2020
|
Looks great, thank you pal! |
|
@nimesulide Just released v1.0, enjoy! https://pypi.org/project/mongodb-migrations/1.0.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.