Update SA1003 to handle the null-coalescing assignment operator, the unsigned right-shift operator, the unsigned right-shift assignment operator and the null-forgiving operator #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unsigned right-shift operator, the unsigned right-shift assignment operator and the null-forgiving operator DotNetAnalyzers#3822
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3823 +/- ##
==========================================
+ Coverage 94.37% 97.45% +3.08%
==========================================
Files 924 925 +1
Lines 109815 110040 +225
Branches 3302 3302
==========================================
+ Hits 103635 107242 +3607
+ Misses 5170 1835 -3335
+ Partials 1010 963 -47 |
|
Ready for review |
sharwell
approved these changes
Apr 8, 2024
bjornhellander
deleted the
feature/sa1003-null-coalescing-assignment-operator-3822
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3822. Also found some more operators that were not being handled by SA1003.