Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support C# 7 via light-up #2370

Merged
merged 31 commits into from
Jun 10, 2017
Merged

Support C# 7 via light-up #2370

merged 31 commits into from
Jun 10, 2017

Conversation

sharwell
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2017

Codecov Report

Merging #2370 into master will decrease coverage by 0.71%.
The diff coverage is 66.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2370      +/-   ##
=========================================
- Coverage   96.01%   95.3%   -0.72%     
=========================================
  Files         607     664      +57     
  Lines       85745   87833    +2088     
  Branches     3358    3428      +70     
=========================================
+ Hits        82328   83709    +1381     
- Misses       2499    3206     +707     
  Partials      918     918
Impacted Files Coverage Δ
...StyleCop.Analyzers/Lightup/RefTypeSyntaxWrapper.cs 0% <0%> (ø)
...leCop.Analyzers/Lightup/WhenClauseSyntaxWrapper.cs 0% <0%> (ø)
....Analyzers/Lightup/TupleExpressionSyntaxWrapper.cs 0% <0%> (ø)
...Cop.Analyzers/Lightup/TupleElementSyntaxWrapper.cs 0% <0%> (ø)
...ers/Lightup/CommonForEachStatementSyntaxWrapper.cs 0% <0%> (ø)
...ers/Lightup/LocalFunctionStatementSyntaxWrapper.cs 0% <0%> (ø)
...s/Lightup/ForEachVariableStatementSyntaxWrapper.cs 0% <0%> (ø)
...op.Analyzers/Lightup/RefExpressionSyntaxWrapper.cs 0% <0%> (ø)
...zers/Lightup/DeclarationExpressionSyntaxWrapper.cs 0% <0%> (ø)
...ers/Lightup/CasePatternSwitchLabelSyntaxWrapper.cs 0% <0%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9ca04...1147f65. Read the comment docs.

@roterdam
Copy link

Is there a released version of this change?

@sharwell
Copy link
Member Author

@roterdam This PR allows us to support C# 7, but doesn't actually update any of the rules to use it. We're still working on updating the rules themselves but I'm hoping to release the first beta that includes this work soon.

@roterdam
Copy link

thank you, eagerly waiting for this as I don't want to remove StyleCop just to use C# 7 features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants