Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SA0002: Invalid settings file #2029

Closed
sharwell opened this issue Jan 7, 2016 · 2 comments
Closed

Implement SA0002: Invalid settings file #2029

sharwell opened this issue Jan 7, 2016 · 2 comments
Assignees
Milestone

Comments

@sharwell
Copy link
Member

sharwell commented Jan 7, 2016

It would be nice to use a compilation end event to report a single instance of this violation if we are unable to deserialize stylecop.json. This would catch (at least) the following situations:

  1. JSON syntax errors (e.g. Analyzer doesn't read stylecop.json. #2028)
  2. Semantic errors, such as using an array instead of a string or an unknown value for an enumerated type

This would not report a diagnostic if the file is not configured correctly.

@nbarbettini
Copy link
Contributor

👍

Will probably be even more helpful in the future when/if the configuration becomes more complex.

@vweijsters
Copy link
Contributor

👍

sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Jan 8, 2016
@sharwell sharwell changed the title Rule proposal: Failed to parse stylecop.json Implement SA0002: Invalid settings file Jan 8, 2016
@sharwell sharwell self-assigned this Jan 8, 2016
@sharwell sharwell added this to the 1.1.0 Beta 1 milestone Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants