Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1648 (inheritdoc must be used with inheriting class) wrongly raised for event #1091

Closed
oatkins opened this issue Jul 30, 2015 · 0 comments
Closed
Assignees
Milestone

Comments

@oatkins
Copy link
Contributor

oatkins commented Jul 30, 2015

An event which implements an interface member wrongly reports SA1648 when it has in its XML documentation.

public interface IX
{
    /// <summary>
    /// Raised when an E happens.
    /// </summary>
    event EventHandler E;
}

public class B
{
    /// <summary>
    /// Raised when a Q happens.
    /// </summary>
    public virtual event EventHandler Q;
}

public class Z : B, IX
{
    /// <inheritdoc />
    public event EventHandler E;

    /// <inheritdoc />
    public override event EventHandler Q
    {
        add { }
        remove { }
    }
}

SA1648 is wrongly reported for E. It is correctly not reported for Q.

@sharwell sharwell added this to the 1.0.0 Beta 4 milestone Jul 30, 2015
@sharwell sharwell self-assigned this Jul 31, 2015
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Jul 31, 2015
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants