Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify search algorithm to improve conversion of resources types #293

Merged
merged 3 commits into from
May 1, 2024

Conversation

shadycuz
Copy link
Member

@shadycuz shadycuz commented May 1, 2024

This should result in better matches when converting a resource from Cloudformation to Terraform. In my limited local testing I was able to match on more resources correctly while not breaking any of the tricky conversions we already test against.

I also fixed a bug where we were not parsing attributes in the Terraform docs correctly because we only checked for one type of markdown list item, when there is a second valid list item possible. It was discussed in #290

shadycuz added 3 commits May 1, 2024 02:29
The list items can start with either "-" or "*".  This change checks for
both forms.
In my limited testing locally, I was able to get better matches without
breaking any of the tricky ones we already test for.
@shadycuz shadycuz added enhancement New feature or request minor labels May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (e22cab6) to head (a84904f).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
- Coverage    89.77%   89.74%   -0.04%     
===========================================
  Files           16       16              
  Lines         1135     1131       -4     
  Branches       184      182       -2     
===========================================
- Hits          1019     1015       -4     
  Misses          82       82              
  Partials        34       34              
Flag Coverage Δ
unit 89.74% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadycuz shadycuz merged commit 1c8128b into develop May 1, 2024
11 checks passed
@shadycuz shadycuz deleted the tweak_search_algo branch May 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant