Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump to use py3.12 #226

Closed
wants to merge 5 commits into from
Closed

deps: bump to use py3.12 #226

wants to merge 5 commits into from

Conversation

chenrui333
Copy link
Contributor

No description provided.

@shadycuz shadycuz changed the base branch from master to develop November 17, 2023 07:10
Copy link
Member

@shadycuz shadycuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thanks for opening this PR. I see that the CICD job is failing and also the Readme mentions 3.9 and doesn't show support for 3.12 in the badge at the top.

These are all minor things that should be easy to fix. If you want me to fix them just let me know and I can take care of it on your branch and in this PR.

Thanks,
Levi

@shadycuz
Copy link
Member

@chenrui333 Thank you for opening this PR. It was the motivation that I needed to finally take a look at the versions on python that are installed in the devcontainer. Which versions of python were supported by the project and which version is the version supported by the project for contributions.

I ended up opening my own PR #235 to make some additional changes. But mainly because this repo is not setup in a way where forks can access my PYPI release token. So if I merge this PR then the release pipeline will fail and then I will have to fix the tags, releases and changelog manually. To cut down on the amount of work, I decided I would just base my branch on yours and open my own PR. Your changes and contributions will still count and you will be on the contributors list once these changes make it into the main branch. Thank you so much for contributing! ❤️ 🚀

@shadycuz shadycuz closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants