Remove erroneous Tags assignment

DontShaveTheYak · Nov 10, 2024 · 11e0d79 · 11e0d79
1 parent 997cee5
commit 11e0d79
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/cf2tf/conversion/overrides.py b/src/cf2tf/conversion/overrides.py
@@ -53,7 +53,6 @@ def tag_conversion(_tc: "TemplateConverter", params: CFParams) -> CFParams:
     original_tags: ListType = params["Tags"]  # type: ignore
     # Handle Cloudformation templates that generate Tags: []
     if not original_tags:
-        params["tags"] = params["Tags"]
         del params["Tags"]
         return params
 

diff --git a/tests/test_convert.py b/tests/test_convert.py
@@ -167,9 +167,8 @@ def test_perform_global_overrides():
 
     assert result is empty_params
     assert "Tags" not in result
-    assert "tags" in result
-    assert isinstance(result["tags"], list)
-    assert [] == result["tags"]
+    assert "tags" not in result
+    assert {} == result
 
     params = {"Tags": [{"Key": "foo", "Value": "bar"}]}
     result = convert.perform_global_overrides("aws_s3_bucket", params, template)