bugfix: fix prospector linter to not fail on unset line number. #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using prospector linter, I encountered strange behavior. It gave this output:
Debugged the code and found out that it was crashing on this PEP8 message:
Turns out, this particular lint message (and probably others aswell), doesn't contain line number, therefore, in
src/client/linters/prospector.ts
, this linegot assigned
undefined
and the next linecrashed with error mentioned above.
This pull request fixes the issue.