fix(identity-trust): disable spring security for identityMinusTrust e…

…ndpoint Signed-off-by: Dominik Pinsel <[email protected]>
DominikPinsel · Aug 2, 2024 · f603113 · f603113
1 parent ae2710f
commit f603113
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 97 deletions.
diff --git a/...a/org/eclipse/tractusx/managedidentitywallets/config/security/PresentationIatpFilter.java b/...a/org/eclipse/tractusx/managedidentitywallets/config/security/PresentationIatpFilter.java
diff --git a/...main/java/org/eclipse/tractusx/managedidentitywallets/config/security/SecurityConfig.java b/...main/java/org/eclipse/tractusx/managedidentitywallets/config/security/SecurityConfig.java
@@ -48,7 +48,6 @@
 import org.springframework.security.oauth2.jwt.JwtDecoders;
 import org.springframework.security.oauth2.jwt.NimbusJwtDecoder;
 import org.springframework.security.web.SecurityFilterChain;
-import org.springframework.security.web.authentication.www.BasicAuthenticationFilter;
 import org.springframework.security.web.util.matcher.AntPathRequestMatcher;
 
 import static org.springframework.http.HttpMethod.GET;
@@ -127,8 +126,7 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
                         .requestMatchers(new AntPathRequestMatcher("/error")).permitAll()
                 ).oauth2ResourceServer(resourceServer -> resourceServer.jwt(jwt ->
                                 jwt.jwtAuthenticationConverter(new CustomAuthenticationConverter(securityConfigProperties.clientId())))
-                                .authenticationEntryPoint(new CustomAuthenticationEntryPoint()))
-                .addFilterAfter(new PresentationIatpFilter(validationService), BasicAuthenticationFilter.class);
+                                .authenticationEntryPoint(new CustomAuthenticationEntryPoint()));
 
         return http.build();
     }

diff --git a/...n/java/org/eclipse/tractusx/managedidentitywallets/controller/PresentationController.java b/...n/java/org/eclipse/tractusx/managedidentitywallets/controller/PresentationController.java
@@ -23,6 +23,7 @@
 
 import com.nimbusds.jwt.SignedJWT;
 import io.swagger.v3.oas.annotations.Parameter;
+import liquibase.util.StringUtil;
 import lombok.RequiredArgsConstructor;
 import lombok.SneakyThrows;
 import lombok.extern.slf4j.Slf4j;
@@ -33,6 +34,7 @@
 import org.eclipse.tractusx.managedidentitywallets.dto.PresentationResponseMessage;
 import org.eclipse.tractusx.managedidentitywallets.reader.TractusXPresentationRequestReader;
 import org.eclipse.tractusx.managedidentitywallets.service.PresentationService;
+import org.eclipse.tractusx.managedidentitywallets.service.STSTokenValidationService;
 import org.eclipse.tractusx.managedidentitywallets.utils.TokenParsingUtils;
 import org.eclipse.tractusx.ssi.lib.model.verifiable.presentation.VerifiablePresentation;
 import org.springframework.http.HttpStatus;
@@ -63,6 +65,8 @@ public class PresentationController {
 
     private final TractusXPresentationRequestReader presentationRequestReader;
 
+    private final STSTokenValidationService validationService;
+
     /**
      * Create presentation response entity.
      *
@@ -114,17 +118,37 @@ public ResponseEntity<Map<String, Object>> validatePresentation(@RequestBody Map
     @PostMapping(path = { RestURI.API_PRESENTATIONS_IATP, RestURI.API_PRESENTATIONS_IATP_WORKAROUND }, produces = { MediaType.APPLICATION_JSON_VALUE })
     @GetVerifiablePresentationIATPApiDocs
     @SneakyThrows
-    public ResponseEntity<PresentationResponseMessage> createPresentation(@Parameter(hidden = true) @RequestHeader(name = "Authorization") String stsToken,
-                                                                          @RequestParam(name = "asJwt", required = false, defaultValue = "false") boolean asJwt,
-                                                                          InputStream is) {
+    public ResponseEntity<PresentationResponseMessage> createPresentation(
+            /* As filters are disabled for this endpoint set required to false and handle missing token manually */
+            @Parameter(hidden = true) @RequestHeader(name = "Authorization", required = false) String stsToken,
+            @RequestParam(name = "asJwt", required = false, defaultValue = "false") boolean asJwt,
+            InputStream is) {
         try {
 
+            if(stsToken == null){
+                return ResponseEntity.status(HttpStatus.UNAUTHORIZED).build();
+            }
+
+            if (stsToken.startsWith("Bearer ")) {
+                stsToken = stsToken.substring("Bearer ".length());
+            }
+
+            var validationResult = validationService.validateToken(stsToken);
+            if (!validationResult.isValid()) {
+                log.atDebug().log("Unauthorized request. Errors: '%s'".formatted(
+                        StringUtil.join(validationResult.getErrors().stream()
+                                        .map(Enum::name)
+                                        .toList(),
+                                ", ")));
+                return ResponseEntity.status(HttpStatus.UNAUTHORIZED).build();
+            }
+
+            // requested scopes are ignored for now
             final List<String> requestedScopes = presentationRequestReader.readVerifiableCredentialScopes(is);
-            // requested scopes are ignored until the documentation is better refined
 
             SignedJWT accessToken = getAccessToken(stsToken);
             Map<String, Object> map = presentationService.createVpWithRequiredScopes(accessToken, asJwt);
-            VerifiablePresentation verifiablePresentation = new VerifiablePresentation((Map)map.get("vp"));
+            VerifiablePresentation verifiablePresentation = new VerifiablePresentation((Map) map.get("vp"));
             PresentationResponseMessage message = new PresentationResponseMessage(verifiablePresentation);
             return ResponseEntity.ok(message);
         } catch (TractusXPresentationRequestReader.InvalidPresentationQueryMessageResource e) {

diff --git a/...va/org/eclipse/tractusx/managedidentitywallets/controller/PresentationIatpFilterTest.java b/...va/org/eclipse/tractusx/managedidentitywallets/controller/PresentationIatpFilterTest.java
@@ -70,7 +70,7 @@ void createPresentationFailure401Test() {
         HttpEntity<String> entity = new HttpEntity<>(headers);
         ResponseEntity<Map<String, Object>> response = testTemplate.exchange(
                 RestURI.API_PRESENTATIONS_IATP,
-                HttpMethod.GET,
+                HttpMethod.POST,
                 entity,
                 new ParameterizedTypeReference<>() {
                 }
@@ -94,15 +94,12 @@ void createPresentationFailure401WithErrorsTest() {
 
         ResponseEntity<String> response = testTemplate.exchange(
                 RestURI.API_PRESENTATIONS_IATP,
-                HttpMethod.GET,
+                HttpMethod.POST,
                 entity,
                 new ParameterizedTypeReference<>() {
                 }
         );
 
-        String expectedBody = TOKEN_ALREADY_EXPIRED.name() + StringPool.COMA_SEPARATOR + NONCE_MISSING.name();
-
         Assertions.assertEquals(HttpStatus.UNAUTHORIZED, response.getStatusCode());
-        Assertions.assertEquals(expectedBody, response.getBody());
     }
 }
diff --git a/...java/org/eclipse/tractusx/managedidentitywallets/identityminustrust/TokenRequestTest.java b/...java/org/eclipse/tractusx/managedidentitywallets/identityminustrust/TokenRequestTest.java
@@ -148,7 +148,7 @@ public void testPresentationQueryWithToken() {
         final Map<String, Object> data2 = MAPPER.readValue(message2, Map.class);
 
         final HttpHeaders headers2 = new HttpHeaders();
-        headers2.set(HttpHeaders.AUTHORIZATION, jwt);
+        headers2.set(HttpHeaders.AUTHORIZATION, "Bearer " + jwt);
         final HttpEntity<Map<String, Object>> entity2 = new HttpEntity<>(data2, headers2);
         var result2 = restTemplate
                 .postForEntity(RestURI.API_PRESENTATIONS_IATP, entity2, String.class);