fix: Allow passing null assigneeId and dueString to unset field #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engfragui
requested review from
a team and
proxi
and removed request for
a team
scottlovegrove
approved these changes
Oct 7, 2022
engfragui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a task via the Todoist API SDK, we want to be able to unset the
assignee_idfield. Following the documentation (https://developer.todoist.com/rest/v2/#update-a-task) this can be done by passing in thenullvalue. This PR is to allow for saidnullvalue to be passed as well.We want to do the same thing for the
dueStringfield (and all the otherdue-related fields).This is needed for our new Task Helper UI Extension (https://github.com/Doist/event-integrations/pull/1117).