fix: Disable cross-frame focus lock in <Modal>
#840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
When using
<Modal>
in a Storybook story, controls would stop working. This was determined to be caused by the<FocusLock>
component, which would prevent interaction with Storybooks preview/add-ons pane once focus was established within the modal (which would happen automatically asautoFocus
defaults totrue
). To fix this, we're limiting<FocusLock>
's focus trap to the document/iframe the Modal is contained within, preventing it from bleeding over into Storybook's preview pane.PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refVersioning