Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --reactist-font-family-monospace with updated font family #813

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

rfgamaral
Copy link
Member

Short description

Adds a new design token variable (i.e. --reactist-font-family-monospace) for monospace font families, uses it everywhere for monospace elements, and updates the font family based on this proposal approved by Julia H.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor release (new design token)

@rfgamaral rfgamaral requested a review from a team January 17, 2024 15:28
@rfgamaral rfgamaral self-assigned this Jan 17, 2024
@rfgamaral rfgamaral requested review from scottlovegrove and removed request for a team January 17, 2024 15:28
@rfgamaral rfgamaral merged commit 3366d1e into main Jan 18, 2024
3 of 5 checks passed
@rfgamaral rfgamaral deleted the ricardo/update-monospace-font-family branch January 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants