Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vertical alignment of inline code inside a Prose component #811

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Jan 5, 2024

Short description

Removes the vertical-align: text-top style from inline code elements inside a Prose component.

Long description

The style vertical-align top is not needed. It causes an almost imperceptible misalignment in most browsers:

Screen recording

CleanShot 2024-01-05 at 12 41 41

But what's worse, in some situation (e.g. a certain Firefox version in Linux, or perhaps any Firefox in Linux), it does this, which is much more extreme:

Screenshot

image

PR Checklist

  • Added tests for bugs / new features (N/A)
  • Updated docs (storybooks, readme) (N/A)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch release

@gnapse gnapse self-assigned this Jan 5, 2024
@gnapse gnapse merged commit 535d69c into main Jan 5, 2024
5 checks passed
@gnapse gnapse deleted the ernesto/fix-prose-code-vertical-alignment branch January 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant