-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update <Alert>
component's design
#806
Conversation
…-border for input components
f410874
to
f77edb0
Compare
src/alert/alert.tsx
Outdated
<Columns space="small" alignY="top"> | ||
<Column width="content"> | ||
<Columns space="small" alignY="center"> | ||
<Column width="content" exceptionallySetClassName={styles.icon}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the class exceptionally preferable to applying styles directly to the svg
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also apply it directly to the SVG 👍 updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, my curiosity was honest and totally not a hint towards a change. 😅
I feel kinda "meh" when looking at this differences and wanted to take the opportunity to learn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem :) applying the class to the column was kinda weird to see anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Short description
This changes the alert component's icons and default colours.
Figma ref
Test Plan
tone="error"
states have a red border, and are using a new--reactist-inputs-alert
variablePR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refVersioning
Minor