feat: Rename Text stack to align with Design library #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieyan
requested review from
a team and
craigcarlyle
and removed request for
a team
|
cc. @gnapse and @Doist/frontend-product so you are aware |
|
@henningmu I suppose that this component could have been used for example in https://github.com/Doist/todoist-web/pull/2983. |
craigcarlyle
approved these changes
May 6, 2021
| --reactist-font-size-small: 12px; | ||
| --reactist-font-size-normal: 14px; | ||
| --reactist-font-size-large: 16px; | ||
| --reactist-font-size-caption: 12px; |
There was a problem hiding this comment.
I love these purpose-based names ❤️
frankieyan
force-pushed
the
frankie/update-text-stack
branch
from
c7f9be3 to
976df36
Compare
Not until we can get rid of IE11 over there since these make use of CSS variables 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This updates the
Textcomponent to align its size and weight stack with the Doist product library. This will allow us to identify font-size tokens easier when working with Figma:Reference: https://twist.com/a/1585/ch/414345/t/2200903/c/65916995
Figma: https://www.figma.com/file/LYlWNzvhMDh907l07mPPQk/Product-Web?node-id=239%3A26
Note that our stories have their font-stack set to Arial, which doesn't seem to support the
semibold/500font-weight. In our products, they should look correct with the system fonts font-stack.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
v9.2.0-beta.10