Skip to content

Commit

Permalink
fix: Set <Prose> horizontal rule color to Divider/Primary (#852)
Browse files Browse the repository at this point in the history
* fix: Use primary border color in Prose <hr>

* refactor: Expose border color as custom CSS prop

* chore: Bump version
  • Loading branch information
pawelgrimm authored Dec 12, 2024
1 parent 5c79f80 commit 75441cd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# 26.2.4

- [Fix] The `Prose` component's horizontal rule color is now properly set to the primary divider color.

# 26.2.3

- [Fix] The `Tab` component's line height is now properly set to 21px.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"email": "[email protected]",
"url": "http://doist.com"
},
"version": "26.2.3",
"version": "26.2.4",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": {
Expand Down
4 changes: 3 additions & 1 deletion src/prose/prose.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
--reactist-prose-link-idle-underline: var(--reactist-divider-primary);
--reactist-prose-link-hover-tint: #006f85;
--reactist-prose-link-hover-underline: #006f85;

--reactist-prose-horizontal-rule-color: var(--reactist-divider-primary);
}

/* Internals for spacing. These are not considered public API. */
Expand Down Expand Up @@ -151,7 +153,7 @@
.prose hr {
margin-block: var(--reactist-prose-space-2);
border: none;
border-top: 1px solid var(--reactist-divider-secondary);
border-top: 1px solid var(--reactist-prose-horizontal-rule-color);
}

/* blockquote */
Expand Down

0 comments on commit 75441cd

Please sign in to comment.