Skip to content

Commit

Permalink
A couple of style fixes (#517)
Browse files Browse the repository at this point in the history
* A couple of style fixes
* Further fixes to the select styles
* Prepare new beta release
  • Loading branch information
gnapse authored May 10, 2021
1 parent b1f8125 commit 3fff3b3
Show file tree
Hide file tree
Showing 19 changed files with 27 additions and 17 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

## v9.2.0-beta.11

- [Fix] Incorrect styles in `Button` which affected dark mode themes
- [Fix] Incorrect styles in `SelectField` which affected dark mode themes

## v9.2.0-beta.10

- [Breaking] `Text` component now has its `size` attribute changed to accept `caption`, `copy`, `body`, and `subtitle`.
Expand Down

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/iframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,4 @@



window['FRAMEWORK_OPTIONS'] = {};</script><script src="runtime~main.233fc521.iframe.bundle.js"></script><script src="vendors~main.7a1034ee.iframe.bundle.js"></script><script src="main.364064a5.iframe.bundle.js"></script></body></html>
window['FRAMEWORK_OPTIONS'] = {};</script><script src="runtime~main.233fc521.iframe.bundle.js"></script><script src="vendors~main.ecdac89f.iframe.bundle.js"></script><script src="main.756525a0.iframe.bundle.js"></script></body></html>
2 changes: 1 addition & 1 deletion docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@



window['DOCS_MODE'] = false;</script><script src="runtime~main.d19817689f726beb264f.manager.bundle.js"></script><script src="vendors~main.2d10f07dc46e02b35c70.manager.bundle.js"></script><script src="main.ecf76ec7b279514afee2.manager.bundle.js"></script></body></html>
window['DOCS_MODE'] = false;</script><script src="runtime~main.024ed10dc6d33032191e.manager.bundle.js"></script><script src="vendors~main.b3d86e7a4108d0e9b0c0.manager.bundle.js"></script><script src="main.ecf76ec7b279514afee2.manager.bundle.js"></script></body></html>
1 change: 0 additions & 1 deletion docs/main.364064a5.iframe.bundle.js

This file was deleted.

1 change: 1 addition & 0 deletions docs/main.756525a0.iframe.bundle.js

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions docs/vendors~main.2d10f07dc46e02b35c70.manager.bundle.js

This file was deleted.

1 change: 0 additions & 1 deletion docs/vendors~main.7a1034ee.iframe.bundle.js.map

This file was deleted.

2 changes: 2 additions & 0 deletions docs/vendors~main.b3d86e7a4108d0e9b0c0.manager.bundle.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/vendors~main.ecdac89f.iframe.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@doist/reactist",
"description": "Open source React components by Doist",
"author": "Henning Muszynski <[email protected]> (http://doist.com)",
"version": "9.2.0-beta.10",
"version": "9.2.0-beta.11",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": "git+https://github.com/Doist/reactist.git",
Expand Down
6 changes: 3 additions & 3 deletions src/components/button/button.less
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

&--primary {
background-color: @primary_color;
color: white !important;
color: white;

&:not([disabled]):hover {
background-color: @primary_color_darker;
Expand All @@ -44,7 +44,7 @@

&--danger {
background-color: @color_red;
color: white !important;
color: white;

&:not([disabled]):hover {
background-color: darken(@color_red, 10%);
Expand All @@ -53,7 +53,7 @@

&--secondary {
background-color: white;
color: @primary_font_color !important;
color: @primary_font_color;
border-color: @color_border_grey;

&:not([disabled]):hover {
Expand Down
5 changes: 5 additions & 0 deletions src/new-components/select-field/select-field.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
appearance: none;
box-sizing: border-box;
width: 100%;
color: var(--reactist-content-primary);
background: none;
border-radius: var(--reactist-border-radius-small);
border: 1px solid var(--reactist-framework-border);
Expand All @@ -41,6 +42,10 @@
margin: 0;
}

.selectWrapper option {
background-color: var(--reactist-bg-aside);
}

.selectWrapper select:focus {
border-color: var(--reactist-framework-border-focus);
}

0 comments on commit 3fff3b3

Please sign in to comment.