Skip to content

Commit

Permalink
Button improvements (#563)
Browse files Browse the repository at this point in the history
* Fix secondary destructive buttons styles
* Change primary destructive button colours for dark mode
* Extract loading spinner icon as independent component
* Add loading state to buttons
* Update button horizontal spacing
* Bring ButtonLink stories up to speed
* Last minute fixes to ButtonLink
* Update CHANGELOG and increment version number
* Adjust sizes, improve customizability of size
* Remove incorrect use of aria-busy
* Use Button to power the ModalCloseButton
* Switch to inline exports to make storybook happy
* Add statically built artifacts
  • Loading branch information
gnapse authored Sep 10, 2021
1 parent 5c4c09e commit 23029df
Show file tree
Hide file tree
Showing 41 changed files with 779 additions and 317 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

## v10.0.0-beta.6

- [Feature] Add a new `loading` prop for `Button` and `ButtonLink`, to set them as busy, and
visually show a loading indicator.
- [Fix] Fully support secondary destructive buttons in a way that is customizable via CSS
variables.
- [Fix] Use the `Button` component to power the default modal close button. This makes it possible
for consumer apps to have these buttons follow their customized button styles.
- [Feature] Improves the ability to fully customize all sizing and spacing by apps via CSS
variables.
- [Docs] New storybook examples showcasing how to customize buttons for dark mode.

## v10.0.0-beta.5

- [Breaking] The various `Menu*` components props no longer consider `className` as a valid prop.
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/4.1b05ad79.iframe.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion docs/4.e80867a9.iframe.bundle.js.map

This file was deleted.

1 change: 0 additions & 1 deletion docs/5.32f68351.iframe.bundle.js

This file was deleted.

1 change: 1 addition & 0 deletions docs/5.a2aae308.iframe.bundle.js

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions docs/6.b3012aa1.iframe.bundle.js

This file was deleted.

1 change: 0 additions & 1 deletion docs/6.b3012aa1.iframe.bundle.js.map

This file was deleted.

3 changes: 3 additions & 0 deletions docs/6.ca642da7.iframe.bundle.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/6.ca642da7.iframe.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/iframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,4 @@



window['FRAMEWORK_OPTIONS'] = {};</script><script src="runtime~main.f9a0230b.iframe.bundle.js"></script><script src="vendors~main.68a5261a.iframe.bundle.js"></script><script src="main.8af9608f.iframe.bundle.js"></script></body></html>
window['FRAMEWORK_OPTIONS'] = {};</script><script src="runtime~main.d7104a8b.iframe.bundle.js"></script><script src="vendors~main.99b4d6cf.iframe.bundle.js"></script><script src="main.e08469b5.iframe.bundle.js"></script></body></html>
1 change: 0 additions & 1 deletion docs/main.8af9608f.iframe.bundle.js

This file was deleted.

1 change: 1 addition & 0 deletions docs/main.e08469b5.iframe.bundle.js

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions docs/vendors~main.68a5261a.iframe.bundle.js

This file was deleted.

1 change: 0 additions & 1 deletion docs/vendors~main.68a5261a.iframe.bundle.js.map

This file was deleted.

3 changes: 3 additions & 0 deletions docs/vendors~main.99b4d6cf.iframe.bundle.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/vendors~main.99b4d6cf.iframe.bundle.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@doist/reactist",
"description": "Open source React components by Doist",
"author": "Henning Muszynski <[email protected]> (http://doist.com)",
"version": "10.0.0-beta.5",
"version": "10.0.0-beta.6",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": "git+https://github.com/Doist/reactist.git",
Expand Down
Loading

0 comments on commit 23029df

Please sign in to comment.