fix(core): handle spaces in workspace path

Closes nrwl#3919
Doginal · Nov 25, 2020 · 7a45b68 · 7a45b68
1 parent 5d73ba5
commit 7a45b68
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/e2e/workspace/src/create-nx-workspace.test.ts b/e2e/workspace/src/create-nx-workspace.test.ts
@@ -1,4 +1,6 @@
-import { forEachCli, runCreateWorkspace, uniq } from '@nrwl/e2e/utils';
+import { cli, forEachCli, runCreateWorkspace, uniq } from '@nrwl/e2e/utils';
+import { existsSync, mkdirSync } from 'fs-extra';
+import { execSync } from 'child_process';
 
 forEachCli(() => {
   describe('create-nx-workspace', () => {
@@ -92,5 +94,22 @@ forEachCli(() => {
         appName,
       });
     });
+
+    it('should handle spaces in workspace path', () => {
+      const wsName = uniq('empty');
+
+      const tmpDir = `./tmp/${cli}/with space`;
+
+      mkdirSync(tmpDir);
+
+      const command = `npx create-nx-workspace@${process.env.PUBLISHED_VERSION} ${wsName} --cli=${cli} --preset=empty --no-nxCloud --no-interactive`;
+      execSync(command, {
+        cwd: tmpDir,
+        stdio: [0, 1, 2],
+        env: process.env,
+      });
+
+      expect(existsSync(`${tmpDir}/${wsName}/package.json`)).toBeTruthy();
+    });
   });
 });
diff --git a/packages/create-nx-plugin/bin/create-nx-plugin.ts b/packages/create-nx-plugin/bin/create-nx-plugin.ts
@@ -73,7 +73,7 @@ function createWorkspace(
     `${packageExec} tao ${command.replace(
       '--collection=@nrwl/workspace',
       `--collection=${collectionJsonPath}`
-    )} --nxWorkspaceRoot=${process.cwd()}`,
+    )} --nxWorkspaceRoot="${process.cwd()}"`,
     {
       stdio: [0, 1, 2],
       cwd: tmpDir,

diff --git a/packages/create-nx-workspace/bin/create-nx-workspace.ts b/packages/create-nx-workspace/bin/create-nx-workspace.ts
@@ -500,7 +500,7 @@ function createApp(
     `${packageExec} tao ${command.replace(
       '--collection=@nrwl/workspace',
       `--collection=${collectionJsonPath}`
-    )} --cli=${cli.command} --nxWorkspaceRoot=${process.cwd()}`,
+    )} --cli=${cli.command} --nxWorkspaceRoot="${process.cwd()}"`,
     {
       stdio: [0, 1, 2],
       cwd: tmpDir,