-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate name in updateValue bug #1929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqnykamp
force-pushed
the
unique_extract
branch
from
February 11, 2023 02:21
f1e39d1
to
38484d9
Compare
dqnykamp
force-pushed
the
unique_extract
branch
from
February 11, 2023 02:23
38484d9
to
3a2eced
Compare
jaltekruse
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
jaltekruse
added a commit
to jaltekruse/DoenetTools
that referenced
this pull request
Apr 8, 2023
Squashed commit of the following: commit 45dc6a5 Merge: bc0398b 0c09423 Author: Kevin Charles <[email protected]> Date: Mon Mar 27 12:57:01 2023 -0500 Merge remote-tracking branch 'upstream/main' into newHomepage commit bc0398b Author: Kevin Charles <[email protected]> Date: Mon Mar 27 17:27:09 2023 +0000 See Inside should now work! commit 528c715 Author: Kevin Charles <[email protected]> Date: Mon Mar 27 16:49:41 2023 +0000 Start of make public. Assigns activity. commit cefbaa8 Author: Kevin Charles <[email protected]> Date: Mon Mar 27 14:31:20 2023 +0000 Not show deleted activities commit 64d253f Author: Kevin Charles <[email protected]> Date: Sun Mar 26 22:13:16 2023 +0000 Jost font commit 9b5f924 Author: Kevin Charles <[email protected]> Date: Sun Mar 26 21:15:51 2023 +0000 Fix z-index to 1200 per Chakra standards commit 35fc95e Author: Kevin Charles <[email protected]> Date: Sun Mar 26 20:27:21 2023 +0000 Fixed Headers zindex and top margin gap commit a3201af Author: Kevin Charles <[email protected]> Date: Sun Mar 26 03:51:55 2023 +0000 Update card size to 180 - fix editor cap image bug commit 5347709 Author: Kevin Charles <[email protected]> Date: Sun Mar 26 02:12:45 2023 +0000 Removed refrences to next_doenetId commit eade9eb Author: Kevin Charles <[email protected]> Date: Sat Mar 25 17:24:25 2023 +0000 React Icons and portfolio menu functionality commit b2cf51f Author: Kevin Charles <[email protected]> Date: Fri Mar 24 21:28:33 2023 +0000 Portfolio card menu and layout update commit a7936f9 Author: Kevin Charles <[email protected]> Date: Fri Mar 24 13:09:34 2023 +0000 Bug fix courseId in settings commit 0ee30ff Author: Kevin Charles <[email protected]> Date: Fri Mar 24 03:43:34 2023 +0000 Settings go to correct referrer commit abe0de0 Author: Kevin Charles <[email protected]> Date: Fri Mar 24 03:01:21 2023 +0000 Portfolio Activity Viewer Avatar and elispe Label commit 83d09d2 Author: Kevin Charles <[email protected]> Date: Thu Mar 23 22:55:09 2023 +0000 Why is Avatar or Chakra Not working? commit ce5df64 Author: Kevin Charles <[email protected]> Date: Thu Mar 23 22:42:59 2023 +0000 Portfolio Public Viewer commit 29a857c Author: Kevin Charles <[email protected]> Date: Thu Mar 23 14:22:40 2023 +0000 half done with viewer commit 36a76b9 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 23:17:16 2023 +0000 Fixed portfolio layout to take up bottom commit 618f6e4 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 23:08:55 2023 +0000 Fixed some links commit 6648553 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 21:32:46 2023 +0000 Setting DND fixed commit 0c09423 Author: Duane Nykamp <[email protected]> Date: Tue Mar 21 16:27:44 2023 -0500 regular polygon (Doenet#1986) commit 4115f83 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 20:57:02 2023 +0000 Loader for portfilio Menu Cap commit 4772f60 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 20:04:55 2023 +0000 Portfolio Editor Menu Cap commit ee6dcd9 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 14:20:47 2023 +0000 Fixed cleanup bug commit 1f092b2 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 13:51:38 2023 +0000 Portfolio Editor Improvements commit e135d52 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 04:00:27 2023 +0000 Add settings only to portfolio page commit 906c661 Author: Kevin Charles <[email protected]> Date: Tue Mar 21 03:47:49 2023 +0000 Menus in editor commit 1de7bbb Author: Kevin Charles <[email protected]> Date: Tue Mar 21 02:41:21 2023 +0000 Fixed activity create commit 4f81dac Author: Kevin Charles <[email protected]> Date: Mon Mar 20 21:27:00 2023 +0000 start of create p activity commit 9eaafa5 Author: Kevin Charles <[email protected]> Date: Mon Mar 20 18:15:47 2023 +0000 React Dom Root commit 6332a99 Merge: 61ccb63 ef7a1b9 Author: Kevin Charles <[email protected]> Date: Mon Mar 20 18:14:31 2023 +0000 Merge remote-tracking branch 'jason/upgrade-to-react-18' into newHomepage commit ef7a1b9 Author: Jason Altekruse <[email protected]> Date: Mon Mar 20 11:44:15 2023 -0500 Remove unneeded depedency, move cypress-parallel to optional depedencies commit 9881551 Author: Jason Altekruse <[email protected]> Date: Fri Mar 17 17:04:17 2023 -0500 Change to use the new API for the root render call reqired in version 18 commit a54e95a Author: Jason Altekruse <[email protected]> Date: Wed Mar 15 13:22:44 2023 -0500 package lock commit a1e79b4 Author: Jason Altekruse <[email protected]> Date: Wed Mar 15 13:15:41 2023 -0500 Upgrade react 18 - also update packages with peer dependencies on react - delete file not referenced anywhere (it happened to also reference a datetime package that has not be updated to be compatible with react 18, but it doesn't matter because we didn't actually need it) - palantir/blueprint#5699 commit b4c8df1 Author: Duane Nykamp <[email protected]> Date: Mon Mar 20 05:05:45 2023 -0500 delay updating renderers until the end of update sequences (Doenet#1995) commit 61ccb63 Merge: 908433c d097e5d Author: Kevin Charles <[email protected]> Date: Mon Mar 20 02:41:01 2023 +0000 Merge remote-tracking branch 'jason/upgrade-to-react-18' into newHomepage commit cf25bb8 Author: Duane Nykamp <[email protected]> Date: Fri Mar 17 19:17:47 2023 -0500 Add support for parallel cypress tests (Doenet#1992) commit d097e5d Author: Jason Altekruse <[email protected]> Date: Fri Mar 17 17:04:17 2023 -0500 Change to use the new API for the root render call reqired in version 18 commit 908433c Author: Kevin Charles <[email protected]> Date: Fri Mar 17 20:59:37 2023 +0000 Half done settings image uploader commit ae86e01 Author: Kevin Charles <[email protected]> Date: Wed Mar 15 22:55:45 2023 +0000 resized image upload. Make it small! commit 669724f Author: Kevin Charles <[email protected]> Date: Wed Mar 15 22:20:54 2023 +0000 Working on upload images commit 4fdd58b Author: Kevin Charles <[email protected]> Date: Wed Mar 15 19:57:41 2023 +0000 Portfolio Layout commit 90f0454 Author: Jason Altekruse <[email protected]> Date: Wed Mar 15 13:22:44 2023 -0500 package lock commit 36ac2e0 Author: Jason Altekruse <[email protected]> Date: Wed Mar 15 13:15:41 2023 -0500 Upgrade react 18 - also update packages with peer dependencies on react - delete file not referenced anywhere (it happened to also reference a datetime package that has not be updated to be compatible with react 18, but it doesn't matter because we didn't actually need it) - palantir/blueprint#5699 commit 917d500 Author: Kevin Charles <[email protected]> Date: Wed Mar 15 03:28:18 2023 +0000 fix update redirect commit 463d8c9 Author: Kevin Charles <[email protected]> Date: Wed Mar 15 03:13:10 2023 +0000 fix bugs - checkbox and redirects commit 44181aa Author: Kevin Charles <[email protected]> Date: Wed Mar 15 02:57:31 2023 +0000 loader sign in test and create portfolio courseId commit e63643b Author: Kevin Charles <[email protected]> Date: Tue Mar 14 03:22:42 2023 +0000 also commit cf288e2 Author: Kevin Charles <[email protected]> Date: Tue Mar 14 03:22:33 2023 +0000 loader for portfolio and start of cards commit aeef05f Author: Kevin Charles <[email protected]> Date: Tue Mar 14 02:11:03 2023 +0000 update activity settings commit 9ff3855 Author: Kevin Charles <[email protected]> Date: Mon Mar 13 23:23:42 2023 +0000 Working on Add Activity for Portfolio commit 6c7667c Author: Kevin Charles <[email protected]> Date: Sat Mar 11 23:14:13 2023 +0000 Start of get settings commit 4c2e593 Author: Kevin Charles <[email protected]> Date: Sat Mar 11 20:24:28 2023 +0000 Add Activity Button wired up commit a691472 Author: Kevin Charles <[email protected]> Date: Sat Mar 11 15:50:59 2023 +0000 navigation and next stage improvements commit 43de336 Author: Kevin Charles <[email protected]> Date: Sat Mar 11 15:15:51 2023 +0000 Layout of portfolio settings commit 2b56054 Author: Kevin Charles <[email protected]> Date: Fri Mar 10 21:09:32 2023 +0000 grid improvement commit 8cbafd9 Author: Kevin Charles <[email protected]> Date: Fri Mar 10 15:40:19 2023 +0000 Css for underline not div commit 08e277b Author: Kevin Charles <[email protected]> Date: Fri Mar 10 04:04:04 2023 +0000 More progress commit 93369f0 Author: Kevin Charles <[email protected]> Date: Thu Mar 9 22:52:20 2023 +0000 Home page is back commit 2b646df Author: Kevin Charles <[email protected]> Date: Thu Mar 9 00:15:16 2023 +0000 Reworking Routes commit 857ca93 Merge: bd91287 1a51537 Author: Kevin Charles <[email protected]> Date: Wed Mar 8 10:15:38 2023 -0600 Merge remote-tracking branch 'upstream/main' into newHomepage commit 1a51537 Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 23:55:54 2023 -0600 bugfixes (Doenet#1984) commit f2d878d Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 21:34:08 2023 -0600 Remove label/math/text from graph on umount (Doenet#1982) commit cef9377 Author: keaganeng <[email protected]> Date: Tue Mar 7 17:46:10 2023 -0600 Keyboard redesign (Doenet#1948) commit bb084b3 Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 15:48:53 2023 -0600 showBorder attribute for graph (Doenet#1981) commit 6b9db14 Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 15:32:53 2023 -0600 forall and exists operators (Doenet#1980) commit 4ad07cf Author: ernzher <[email protected]> Date: Wed Mar 8 04:54:22 2023 +0800 Fix mailto in ref (Doenet#1971) commit e07efad Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 12:23:43 2023 -0600 tweaks to pegboard (Doenet#1979) commit b7c8f3a Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 12:17:16 2023 -0600 handGraded attribute for answer (Doenet#1977) commit c4955ac Author: Duane Nykamp <[email protected]> Date: Tue Mar 7 12:17:02 2023 -0600 Addeed expanded attribute to answer (Doenet#1976) commit 0f2ca51 Author: Duane Nykamp <[email protected]> Date: Mon Mar 6 21:18:18 2023 -0600 Expose curve component functions as public state variables (Doenet#1970) commit 1115c12 Author: Kevin Charles <[email protected]> Date: Mon Mar 6 14:55:11 2023 -0600 Grade override (Doenet#1955) commit f84503d Author: Duane Nykamp <[email protected]> Date: Mon Mar 6 14:53:37 2023 -0600 pegboard for graph (Doenet#1968) commit d06e9c2 Author: Duane Nykamp <[email protected]> Date: Mon Mar 6 14:51:58 2023 -0600 nested list items switch numbering scheme (Doenet#1969) commit bd91287 Author: Kevin Charles <[email protected]> Date: Mon Mar 6 14:59:33 2023 +0000 More progress on Home commit 8f04abb Author: Kevin Charles <[email protected]> Date: Sun Mar 5 23:07:14 2023 +0000 Start of navigation using NavItem and Outlet commit fdbdbe2 Author: Duane Nykamp <[email protected]> Date: Fri Mar 3 17:02:47 2023 -0600 doenetML state variable and displayDoenetML component (Doenet#1964) commit 388f8e1 Author: ernzher <[email protected]> Date: Sat Mar 4 06:31:47 2023 +0800 Fix: mathinput color (Doenet#1944) commit 62b0d0f Author: ernzher <[email protected]> Date: Sat Mar 4 06:28:07 2023 +0800 Fix: slider and label color (Doenet#1943) commit 77fc546 Author: ernzher <[email protected]> Date: Sat Mar 4 06:19:45 2023 +0800 Fix: graph tick color (Doenet#1942) commit 3420b63 Author: Duane Nykamp <[email protected]> Date: Fri Mar 3 14:43:28 2023 -0600 navigateToTarget action on ref tag (Doenet#1961) Resolves Doenet#1835 commit e2af37f Author: Kevin Charles <[email protected]> Date: Fri Mar 3 20:34:40 2023 +0000 More code commit 91b9357 Author: Duane Nykamp <[email protected]> Date: Fri Mar 3 14:18:56 2023 -0600 perform vector simplication before comparisons (Doenet#1962) commit 13eaf59 Author: Duane Nykamp <[email protected]> Date: Fri Mar 3 14:15:49 2023 -0600 fix a few regressions and bugs (Doenet#1959) commit e15b412 Merge: a3e70ac 22bc934 Author: Kevin Charles <[email protected]> Date: Wed Mar 1 08:47:05 2023 -0600 Merge remote-tracking branch 'upstream/main' into newHomepage commit a3e70ac Author: Kevin Charles <[email protected]> Date: Wed Mar 1 04:54:27 2023 +0000 Add Activity button portfolio commit 597b2d6 Author: Kevin Charles <[email protected]> Date: Wed Mar 1 04:44:29 2023 +0000 Fix footer gap issue commit fafced0 Author: Kevin Charles <[email protected]> Date: Wed Mar 1 04:40:19 2023 +0000 All three pages commit 22bc934 Author: Duane Nykamp <[email protected]> Date: Tue Feb 28 16:48:53 2023 -0600 New math features (Doenet#1949) This brings in changes from the math expressions library for commits between ab71641e5e1171c352af0941eaaf2624cea77216 and dd6c3b286cb1f78e897b0b3baa363374913e08d2 Summary of changes in new version of math expressions: - enable numerical comparison of vecs - add line segments - set containment with equality - begin support for integrals - introduce a few units - angle as operator, normalize arg order when compare - parallel operator - perp operator and lone symbol - altvector with langle/rangle notation - binom, vec, angle, floor, ceil exponents of non trig function are not moved outside - latex operatorname, nCr, nPr - evaluate log_b(a) - function raised to -1 don't become reciprocal - remove "\\," from latex output of factors commit 8f5418e Author: Duane Nykamp <[email protected]> Date: Fri Feb 24 20:43:51 2023 +0000 verticesDraggable/endpointsDraggable attributes for polygons/polylines/lineSegments commit c88695c Author: Duane Nykamp <[email protected]> Date: Fri Feb 24 20:10:09 2023 +0000 vector magnitude commit ec906e8 Author: Duane Nykamp <[email protected]> Date: Sat Feb 25 04:38:08 2023 +0000 invertible and symbolic line segment length commit c2e1815 Author: Duane Nykamp <[email protected]> Date: Tue Feb 28 11:04:51 2023 -0600 copyDoenetMLToClipboard action on all components (Doenet#1952) commit 35dad7a Author: Kevin Charles <[email protected]> Date: Tue Feb 28 04:07:59 2023 +0000 Logo in header commit 0d5cfe9 Author: Kevin Charles <[email protected]> Date: Tue Feb 28 03:42:05 2023 +0000 Start of header home page commit 33083b9 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 14:23:06 2023 -0600 fix animation stopping bug (Doenet#1950) commit 786bb41 Author: Duane Nykamp <[email protected]> Date: Thu Feb 9 23:29:12 2023 -0600 Don't trigger child updates when children unchanged commit 4b20665 Author: Duane Nykamp <[email protected]> Date: Thu Feb 9 20:37:08 2023 -0600 Change update arrays to sets commit 14db5a6 Author: Duane Nykamp <[email protected]> Date: Tue Feb 7 19:37:19 2023 -0600 Prevent duplicate renderer updates with invalid children commit 26afeba Author: Kevin Charles <[email protected]> Date: Mon Feb 27 19:30:21 2023 +0000 display flaw in textStyle commit 6834848 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 13:22:42 2023 -0600 Fix duplicate name in updateValue bug (Doenet#1929) commit a5e544a Merge: e2e0d15 ff5bfe2 Author: Kevin Charles <[email protected]> Date: Mon Feb 27 13:21:27 2023 -0600 Merge remote-tracking branch 'upstream/main' into newHomepage commit ff5bfe2 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 13:11:36 2023 -0600 ref opens new tab with createButton (Doenet#1932) commit a304b27 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 13:09:09 2023 -0600 EmphasizeRightAngle attribute for angle (Doenet#1924) commit 6fc5400 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 13:05:07 2023 -0600 bug fix: correctly withhold replacements when shadowing (Doenet#1930) commit ac56ef2 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 12:58:32 2023 -0600 Renderers protect again null children (Doenet#1927) commit e8adde8 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 12:41:01 2023 -0600 formula can be an answer response (Doenet#1933) commit 63e8005 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 12:40:32 2023 -0600 ref in placement exam uses exam tool (Doenet#1809) commit 1cb7601 Author: Duane Nykamp <[email protected]> Date: Mon Feb 27 12:39:15 2023 -0600 Rotate image inside a graph (Doenet#1923) commit 568adae Author: Duane Nykamp <[email protected]> Date: Fri Feb 24 22:25:14 2023 +0000 added triggering utility functions to reduce duplicate code commit 03a9832 Author: Duane Nykamp <[email protected]> Date: Wed Feb 15 19:21:05 2023 -0600 rename to triggerWhenObjectsFocused commit 83e65e8 Author: Duane Nykamp <[email protected]> Date: Sat Feb 11 21:41:04 2023 -0600 mouse down action on remaining graphical components commit fa02d92 Author: Duane Nykamp <[email protected]> Date: Sat Feb 11 20:23:31 2023 -0600 triggerWhenMouseDownOnObjects, down action for point commit 34e5d68 Author: Duane Nykamp <[email protected]> Date: Sat Feb 11 12:25:18 2023 -0600 createTargetComponentNames attribute type commit 933f290 Author: Emilio Alvarez <[email protected]> Date: Fri Feb 24 11:07:34 2023 -0600 update dev container (Doenet#1951) * update to support git on linux * add github pr to extension list * add xml tools and gitlens commit e2e0d15 Author: Kevin Charles <[email protected]> Date: Fri Feb 17 23:38:54 2023 +0000 Database update and card update commit 619b0fc Author: Kevin Charles <[email protected]> Date: Fri Feb 17 04:53:16 2023 +0000 Temp Carousel commit 2ceccc3 Author: Kevin Charles <[email protected]> Date: Thu Feb 16 22:51:31 2023 +0000 More work on Carousel commit df08392 Author: Kevin Charles <[email protected]> Date: Thu Feb 16 22:33:16 2023 +0000 HP Create Content section commit e6cc445 Author: Kevin Charles <[email protected]> Date: Thu Feb 16 17:39:44 2023 +0000 Carousel commit 51baff6 Author: Kevin Charles <[email protected]> Date: Wed Feb 15 23:31:54 2023 +0000 minor commit 38f9a02 Author: Kevin Charles <[email protected]> Date: Mon Feb 13 04:41:03 2023 +0000 And header is responsive commit 4a9a448 Author: Kevin Charles <[email protected]> Date: Mon Feb 13 04:28:06 2023 +0000 Improved Responsive design commit f9691b0 Author: Kevin Charles <[email protected]> Date: Mon Feb 13 01:57:39 2023 +0000 working on responsive design commit 304524d Merge: 24cb133 59cae9b Author: Kevin Charles <[email protected]> Date: Fri Feb 10 15:52:57 2023 +0000 Merge remote-tracking branch 'upstream/main' into fixBug2 commit 24cb133 Author: Kevin Charles <[email protected]> Date: Thu Feb 9 22:28:10 2023 +0000 Database Based Carousel commit 6ffb2b4 Author: Kevin Charles <[email protected]> Date: Thu Feb 9 14:49:58 2023 +0000 live example text commit 56c2659 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 22:54:11 2023 +0000 Fixes and kitten commit 69b37f4 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 22:36:07 2023 +0000 Carousel Proof of Concept commit 59cae9b Author: Duane Nykamp <[email protected]> Date: Wed Feb 8 14:46:06 2023 -0600 textinput max width is 100% (Doenet#1905) commit 69b7361 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 19:18:11 2023 +0000 Learn is complete commit f722719 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 18:37:55 2023 +0000 Updated doenetML and fix for getEventData.php commit 0b5613a Author: Kevin Charles <[email protected]> Date: Wed Feb 8 17:26:39 2023 +0000 Doenet Viewer in place commit 8cd1a1f Author: Kevin Charles <[email protected]> Date: Wed Feb 8 15:52:36 2023 +0000 Video update commit 840d1ef Author: Kevin Charles <[email protected]> Date: Wed Feb 8 03:03:13 2023 +0000 Responsive design commit 1cf9ed6 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 02:36:37 2023 +0000 Autoplay video commit 78b25e0 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 00:23:00 2023 +0000 Autoplay doesn't work commit 136f048 Author: Kevin Charles <[email protected]> Date: Wed Feb 8 00:08:43 2023 +0000 Headers for new home page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1921