Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend existing sharedfiles implementation #344

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

3urobeat
Copy link
Contributor

@3urobeat 3urobeat commented May 7, 2024

Hi,
this PR extends the existing sharedfiles implementation to...:

  • detect workshop item objects as type
  • scrape categories
  • scrape tags
  • implement functions to un-/subscribe from/to workshop items
  • rename object methods for un-/subscribing from/to comments to separate them more clearly

Workshop Items are also listed as sharedfiles on the SteamCommunity (see the CS2 Insertion2 map for example), which is why I added support to the existing sharedfiles class, instead of adding a new one.

This PR might display conflicts later on as it is based on the master branch and not on the fixes of my two other sharedfiles PRs (#315 & #316). I'll address them gladly when it is time.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant