Remove usage of process.chdir from language parser

[scholtzm]

The problem

Electron's asar archive does not allow process.chdir to be set inside the archive itself. However, the language parser in steam resources sets working directory when parsing files.

When packaging this module inside asar archive, it will simply fail to load. Skipping archiving is not an option since the dependency tree may contain very large paths and makes it "almost" impossible to work on Windows.

TL;DR Remove process.chdir calls to make the module fully compatible with Electron's standard asar archive format.

Official docs:

• https://electron.atom.io/docs/tutorial/application-packaging/#working-directory-can-not-be-set-to-directories-in-archive

Related issues:

• process.chdir should support asar paths electron/electron#2081
• __dirname in app.asar.unpacked points to app.asar electron/electron#8206
• Asar packaging scholtzm/punk#22

Affected files

• https://github.com/DoctorMcKay/node-steam-client/blob/master/steam-resources/steam_language_parser/index.js#L10
  • sets cwd, loads root file, resets cwd
• https://github.com/DoctorMcKay/node-steam-client/blob/master/steam-resources/steam_language_parser/parser/token_analyzer.js#L34
  • loads imports according to previously set cwd

Solution

We can preload language files and simply serve them from cache. No need to tinker with cwd.

There might be a simpler, more elegant solution so let's discuss.

[DoctorMcKay]

Is there any particular reason why you didn't just remove chdir calls and instead prefix the readFileSync calls with __dirname? I won't reject the way you did it, just curious.

[scholtzm]

I could remove chdir calls from here and simply readFileSync with full path, but in this file, analyzer doesn't know where the imported file is located. At this point, process.cwd() = steam-resources/steam_language_parser and __dirname = steam-resources/steam_language_parser/parser.

[scholtzm]

Might be a good idea to throw here in case file_cache.cache[text.value] is undefined.

[scholtzm]

I think we could also prefix text.value here with hardcoded path e.g. ../../steam_language and this ought to work as well.

Need to be careful when changing build script.