Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect name for steamid variable in requestLiveGameForUser #28

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

Yaroslav-95
Copy link
Contributor

There is an error inside the requestLiveGameForUser method, where the steamid variable is incorrenctly referenced as sid

Also, I have a question regarding the requestRecentGames function. It doesn't return anything, unless you specify your own steamID. Is that the way it should behave? I am looking for a way to get the Sharecode from a match after it has ended.

@DoctorMcKay
Copy link
Owner

Thanks for the bugfix.

Also, I have a question regarding the requestRecentGames function. It doesn't return anything, unless you specify your own steamID. Is that the way it should behave? I am looking for a way to get the Sharecode from a match after it has ended.

I'm sorry, I don't know how the GC is supposed to act for this.

@DoctorMcKay DoctorMcKay merged commit 8923fa4 into DoctorMcKay:master Jun 13, 2019
@Yaroslav-95
Copy link
Contributor Author

Thanks for the bugfix.

My pleasure. Thank you for writing this module!

Do you have any ideas how I could find such a method for obtaining the Sharecode? As far as I am aware, all of the methods that are currently available in your module were reverse-engineered. If that's so, how did you go about reverse-engineering them?

@DoctorMcKay
Copy link
Owner

I don't really do CS:GO. Can you give me an example of a sharecode?

@Yaroslav-95
Copy link
Contributor Author

It's a string of text that allows you to open another person's match demo, it looks like this CSGO-3KBvR-JthRe-hiYnN-9yiiC-soi9Q

@DoctorMcKay
Copy link
Owner

Doesn't look like it's base64 or something like that (although I could be wrong), so it's probably issued by the GC in some message.

@Yaroslav-95
Copy link
Contributor Author

It's supposed to be decoded into three parts, matchid, outcomeid, and token. But I haven't found a way to find that data besides the matchid. This information is required to get the link to a player's demo/replay file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants