Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black formatter integration #68

Merged
merged 4 commits into from
Apr 26, 2020
Merged

Conversation

nahuelhds
Copy link
Contributor

@nahuelhds nahuelhds commented Apr 26, 2020

The Black formatter has been integrated to the repo and it has been ran over all the files.

Closes #66

Post-install instructions

Just execute

pre-commit install

That will install the pre-commit hook to your local repo so black and the other three hooks are executed before any commit.

I've added the instructions on the readme as well

@nahuelhds
Copy link
Contributor Author

@edsu take a look at the .env test here. The problem was that I was creating the file in the root of the project. I've made it to be created in the test folder as well so it doesn't conflict with the Travis one. Anyway I didn't erase the @pytest.mark.skipif just in case. But maybe now it works even on Travis

@edsu edsu merged commit 277ba02 into DocNow:master Apr 26, 2020
@edsu
Copy link
Member

edsu commented Apr 26, 2020

Ok, I think I've got this merged into master. I'm testing without skipping the test on Travis now.

@nahuelhds nahuelhds deleted the feature/black-formatter branch April 26, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python code formatter integration
2 participants