Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get and non-returning effect/effect_one for variant #290

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

tom91136
Copy link
Contributor

This PR addresses #285

The following additions/changes were made:

  • Removed an extra <iostream> header, probably introduced during debugging.
  • Added effect_one and effect for void lambdas.
  • Added get that returns a maybe for extracting values.

@Dobiasd
Copy link
Owner

Dobiasd commented Dec 26, 2023

Removed an extra <iostream> header, probably introduced during debugging.

Oh, thanks! ^^

Added effect_one and effect for void lambdas.

Perfect. 👍

Added get that returns a maybe for extracting values.

This will play together really nice with the new monadic (fluent) interface for maybe from the other PR. (E.g.: some_variant.get<int>().get_with_default(42)). 💯

@Dobiasd Dobiasd merged commit ec95b80 into Dobiasd:master Dec 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants