Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cypress Tests for League Admin Event Crud #529

Merged
merged 5 commits into from
Mar 27, 2022

Conversation

IanjhPhillips
Copy link
Collaborator

Description

Closes #439
Creates league admin user in db seeders
Uses new user in new league admin crud tests

@IanjhPhillips IanjhPhillips added this to the Sprint #9 milestone Mar 24, 2022
@IanjhPhillips IanjhPhillips self-assigned this Mar 24, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 24, 2022

Code Climate has analyzed commit 9e845db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real problem i see here is the ~35 seconds of idle time at the start of the video — but i suppose that's unavoidable since the seeder has to run. Otherwise seems pretty good to me!

Copy link
Collaborator

@pascwhale pascwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. This is an optional change but we could maybe use the same seederLogin function and use an optional parameter to determine which account we log into.

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
81.5% 81.5% Duplication

@IanjhPhillips IanjhPhillips merged commit 3116330 into main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Tests for League Admin Event Control
4 participants