-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Cypress Tests for League Admin Event Crud #529
Conversation
Code Climate has analyzed commit 9e845db and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 92.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only real problem i see here is the ~35 seconds of idle time at the start of the video — but i suppose that's unavoidable since the seeder has to run. Otherwise seems pretty good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. This is an optional change but we could maybe use the same seederLogin
function and use an optional parameter to determine which account we log into.
Kudos, SonarCloud Quality Gate passed! |
Description
Closes #439
Creates league admin user in db seeders
Uses new user in new league admin crud tests