Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react import in favor of new JSX transform #483

Merged
merged 8 commits into from
Mar 12, 2022
Merged

Remove react import in favor of new JSX transform #483

merged 8 commits into from
Mar 12, 2022

Conversation

willyyhuang
Copy link
Contributor

This branch is taking advantage of new React version's feature about new JSX transformation.

Read more: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

Makes the code a little cleaner in general, other than that, using the newest standard is always a good to have.

@codeclimate
Copy link

codeclimate bot commented Mar 9, 2022 •
edited
Loading

Code Climate has analyzed commit a20c7b2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.2% (0.0% change).

View more on Code Climate.

@willyyhuang willyyhuang added chore This issue concerns general maintenance and updates front end refactor Code has been changed, but functionality is staying relatively the same labels Mar 9, 2022
m-triassi
m-triassi requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo to fix; as an aside, i can appreciate wanting to add nice shiny new react features into the project, lets focus on doing tasks that progress the user stories instead

resources/js/Components/Form/CharacterCreateForm.test.js Outdated Show resolved Hide resolved
pascwhale
pascwhale requested changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@pascwhale pascwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I added a comment where you're changing one of the faction names to be incorrect. Otherwise, everything works locally on my machine.

resources/js/Components/Form/CharacterCreateForm.test.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

m-triassi
m-triassi approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is fine

@willyyhuang willyyhuang merged commit 9122494 into main Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-triassi m-triassi m-triassi approved these changes

@pascwhale pascwhale Awaiting requested review from pascwhale

Assignees
No one assigned
Labels
chore This issue concerns general maintenance and updates front end refactor Code has been changed, but functionality is staying relatively the same
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willyyhuang @m-triassi @pascwhale