-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove react import in favor of new JSX transform #483
Remove react import in favor of new JSX transform #483
Conversation
Code Climate has analyzed commit a20c7b2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 92.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo to fix; as an aside, i can appreciate wanting to add nice shiny new react features into the project, lets focus on doing tasks that progress the user stories instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. I added a comment where you're changing one of the faction names to be incorrect. Otherwise, everything works locally on my machine.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is fine
This branch is taking advantage of new React version's feature about new JSX transformation.
Read more: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
Makes the code a little cleaner in general, other than that, using the newest standard is always a good to have.