Filter event controller index results #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was causing an infinite recursion loop
m-triassi
reviewed
Mar 8, 2022
| @@ -16,8 +16,11 @@ class EventController extends Controller | |||
| */ | |||
| public function index(Request $request) | |||
| { | |||
| $events = Event::all(); | |||
| $events = Event::whereRegistered() | |||
There was a problem hiding this comment.
if you have this here, it means that we're always filtering the events by if a user is registered or not. What you'd want to do is check for a flag like $request->has('registered_only') or what ever name you want in an if statement, if it has that then you add the whereRegistered() call, otherwise don't add it
bcobo341
added
back end
enhancement
bcobo341
requested review from
m-triassi,
IanjhPhillips,
JasonGadoury and
RobertoNittolo
m-triassi
requested changes
Mar 10, 2022
| $response = $this->actingAs($user)->get(route('event.index', [ | ||
| 'search' => $event->title, | ||
| 'registered_only' => true, | ||
| 'registered_user' => $user->id, |
There was a problem hiding this comment.
what about a test for if registered_user is null? i suspect it likely will be null since 99% of the time we're filtering this list for the logged in user, which whereRegistered() does automatically
|
Kudos, SonarCloud Quality Gate passed! |
m-triassi
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #437